Skip to content

Updating CONTRIBUTING.md and CONTRIBUTING_COMMON_ERRORS.md #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Updating CONTRIBUTING.md and CONTRIBUTING_COMMON_ERRORS.md #1512

merged 1 commit into from
Aug 9, 2022

Conversation

@LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Aug 9, 2022

Description of changes

  1. An entry was added to CONTRIBUTING_COMMON_ERRORS page which specifies that the IAM role used by CloudFormation needs to be added as a Lake Formation admin.
  2. Fix instructions for how to run a unit test for the databases. This guide was previously referencing a non-existent test file.

Relates

#1497

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger linked an issue Aug 9, 2022 that may be closed by this pull request
Issues in the contributing guidelines #1497
Closed
@malachi-constant malachi-constant added the documentation Improvement or bugfixes on docs label Aug 9, 2022
@malachi-constant
Copy link
Contributor

malachi-constant commented Aug 9, 2022

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 88f6c63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jaidisido
jaidisido approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@jaidisido jaidisido merged commit 6882a72 into main Aug 9, 2022
@jaidisido jaidisido deleted the 1497-issues-in-the-contributing-guidelines branch August 9, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaidisido jaidisido jaidisido approved these changes

+1 more reviewer

@malachi-constant malachi-constant malachi-constant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvement or bugfixes on docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues in the contributing guidelines

3 participants

@LeonLuttenberger @malachi-constant @jaidisido