Skip to content

(enhancement): Remove unnecessary LF permissions from tests infra #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

(enhancement): Remove unnecessary LF permissions from tests infra #1605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions CONTRIBUTING_COMMON_ERRORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,22 +111,3 @@ brew install unixodbc
```

-----

## CloudFormation Deployment

### Error Message

During the deployment of `aws-sdk-pandas-databases`, the creation of the resource `CodeBuildTestRoleLFPermissions` fails with

```
Resource does not exist or requester is not authorized to access requested permissions. (Service: AWSLakeFormation; Status Code: 400; Error Code: AccessDeniedException; Request ID: 14a26718-ee4e-49f2-a7ca-d308e49485f8; Proxy: null)
```

### Solution

The IAM role used to deploy the CloudForation stack does not have permissions to assign permissions in AWS Lake Formation. The quickest solution is to find the IAM role and set it as an admin in Lake Formation.

In order to find the role:
1. Navigate to the CloudFormation console in your account
1. Select the `aws-sdk-pandas-databases` stack which failed to deploy
1. Under the "Stack info" tab, find the value for "IAM role". The name of the role should be in the following format: `arn:aws:iam::{ACCOUNT_ID}:role/cdk-{UUID}-cfn-exec-role-{ACCOUNT_ID}-{REGION}`
17 changes: 4 additions & 13 deletions test_infra/stacks/databases_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from aws_cdk import aws_glue_alpha as glue
from aws_cdk import aws_iam as iam
from aws_cdk import aws_kms as kms
from aws_cdk import aws_lakeformation as lf
from aws_cdk import aws_neptune_alpha as neptune
from aws_cdk import aws_rds as rds
from aws_cdk import aws_redshift_alpha as redshift
Expand Down Expand Up @@ -217,19 +216,11 @@ def _setup_redshift(self) -> None:
),
},
)
lf.CfnPermissions(
ssm.StringParameter(
self,
"CodeBuildTestRoleLFPermissions",
data_lake_principal=lf.CfnPermissions.DataLakePrincipalProperty(
data_lake_principal_identifier=redshift_role.role_arn
),
resource=lf.CfnPermissions.ResourceProperty(
table_resource=lf.CfnPermissions.TableResourceProperty(
database_name="aws_sdk_pandas",
table_wildcard={}, # type: ignore
)
),
permissions=["SELECT", "ALTER", "DESCRIBE", "DROP", "DELETE", "INSERT"],
"redshift-role-arn-parameter",
parameter_name="/SDKPandas/IAM/RedshiftRoleArn",
string_value=redshift_role.role_arn,
)
redshift.ClusterSubnetGroup(
self,
Expand Down