Skip to content

Unit tests: Wrap redshift connectors in with block #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

Unit tests: Wrap redshift connectors in with block #2102

merged 1 commit into from
Mar 8, 2023

Conversation

@LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Mar 7, 2023 •
edited
Loading

Feature or Bugfix

  • Chore

Detail

  • Wrap redshift connectors in with block
  • Also added type annotations for the Redshift unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review March 7, 2023 22:52
@LeonLuttenberger LeonLuttenberger requested review from cnfait, jaidisido, kukushking and malachi-constant and removed request for jaidisido March 7, 2023 22:52
@malachi-constant
Copy link
Contributor

malachi-constant commented Mar 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 07a9aca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Mar 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
  • Commit ID: 07a9aca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Mar 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-ATYtnXPE7MOa
  • Commit ID: 07a9aca
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit 4b6e54a into release-3.0.0 Mar 8, 2023
@LeonLuttenberger LeonLuttenberger deleted the tests/redshift-connector-with branch March 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

+1 more reviewer

@cnfait cnfait cnfait approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LeonLuttenberger @malachi-constant @kukushking @jaidisido @cnfait