Skip to content

fix: Modin .dt() AttributeError #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kukushking merged 3 commits into from
Apr 11, 2023
Merged

fix: Modin .dt() AttributeError #2188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61f0b12
Fix Modin .dt accessor AttributeError
kukushking Apr 11, 2023
0685e12
Merge branch 'main' into fix/modin-dt-attribute-error
kukushking Apr 11, 2023
c5db619
Merge branch 'main' into fix/modin-dt-attribute-error
kukushking Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions awswrangler/athena/_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ def _fix_csv_types(df: pd.DataFrame, parse_dates: List[str], binaries: List[str]
"""Apply data types cast to a Pandas DataFrames."""
if len(df.index) > 0:
for col in parse_dates:
try:
if pd.api.types.is_datetime64_any_dtype(df[col]):
df[col] = df[col].dt.date.replace(to_replace={pd.NaT: None})
except AttributeError:
else:
df[col] = (
df[col].replace(to_replace={pd.NaT: None}).apply(lambda x: date.fromisoformat(x) if x else None)
)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_athena.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,4 +1401,4 @@ def test_athena_date_recovery(path, glue_database, glue_table):
database=glue_database,
ctas_approach=False,
)
assert df.equals(df2)
assert pandas_equals(df, df2)