fix: Engine initialization did not respect OS env #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
LeonLuttenberger
requested review from
cnfait,
jaidisido,
kukushking and
malachi-constant
This comment was marked as outdated.
This comment was marked as outdated.
jaidisido
reviewed
Jun 1, 2023
jaidisido
approved these changes
Jun 1, 2023
malachi-constant
approved these changes
Jun 1, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Engine initialization did not respect OS env. When importing
awswrangler,engine.registergets called. This function looks at only the value of thenameparameter (Nonein this case) or the output ofengine.get_installed().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.