Skip to content

fix: Engine initialization did not respect OS env #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2023
Merged

fix: Engine initialization did not respect OS env #2311

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
456cc3f
fix: Engine initialization did not respect OS env
LeonLuttenberger May 31, 2023
f91cf24
Merge branch 'main' into fix-engine-lazy-init
LeonLuttenberger Jun 1, 2023
228e1d3
Merge branch 'main' into fix-engine-lazy-init
LeonLuttenberger Jun 1, 2023
fbb7947
fix register
LeonLuttenberger Jun 1, 2023
8aae960
Merge branch 'main' into fix-engine-lazy-init
LeonLuttenberger Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions awswrangler/_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,14 @@
from importlib import reload
from typing import Any, Callable, Dict, Literal, Optional, TypeVar, cast

WR_ENGINE = os.getenv("WR_ENGINE")
WR_MEMORY_FORMAT = os.getenv("WR_MEMORY_FORMAT")
EngineLiteral = Literal["python", "ray"]
MemoryFormatLiteral = Literal["pandas", "modin"]

FunctionType = TypeVar("FunctionType", bound=Callable[..., Any])


WR_ENGINE: Optional[EngineLiteral] = os.getenv("WR_ENGINE") # type: ignore[assignment]
WR_MEMORY_FORMAT: Optional[MemoryFormatLiteral] = os.getenv("WR_MEMORY_FORMAT") # type: ignore[assignment]


@unique
Expand All @@ -31,11 +37,6 @@ class MemoryFormatEnum(Enum):
PANDAS = "pandas"


EngineLiteral = Literal["python", "ray"]
MemoryFormatLiteral = Literal["pandas", "modin"]
FunctionType = TypeVar("FunctionType", bound=Callable[..., Any])


class Engine:
"""Execution engine configuration class."""

Expand Down Expand Up @@ -111,7 +112,7 @@ def wrapper(*args: Any, **kw: Dict[str, Any]) -> Any:
def register(cls, name: Optional[EngineLiteral] = None) -> None:
"""Register the distribution engine dispatch methods."""
with cls._lock:
engine_name = cast(EngineLiteral, name or cls.get_installed().value)
engine_name = cast(EngineLiteral, name or cls.get().value)
cls.set(engine_name)
cls._registry.clear()

Expand Down