Skip to content

Fixed lumen support #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2016
Merged

Fixed lumen support #91

merged 2 commits into from
Jan 18, 2016

Conversation

@GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jan 16, 2016

No description provided.

@GrahamCampbell GrahamCampbell mentioned this pull request Jan 16, 2016
Closed
jeskew
jeskew reviewed Jan 16, 2016
View reviewed changes
src/AwsServiceProvider.php Outdated
Copy link
Contributor

@jeskew jeskew Jan 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be $this->app?

Copy link
Contributor Author

@GrahamCampbell GrahamCampbell Jan 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, oops

@jeskew
Copy link
Contributor

jeskew commented Jan 16, 2016

I think I'd like to add a Lumen version of the ServiceProvider test.

@GrahamCampbell
Copy link
Contributor Author

GrahamCampbell commented Jan 16, 2016

I think I'd like to add a Lumen version of the ServiceProvider test.

That won't be possible since you can't install laravel and lumen at the same time.

@jeskew jeskew mentioned this pull request Jan 16, 2016
Merged
@jeskew jeskew merged commit 11fd1a7 into aws:master Jan 18, 2016
@GrahamCampbell GrahamCampbell deleted the patch-1 branch January 18, 2016 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GrahamCampbell @jeskew