Fix Lumen support #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jeskew I wouldn't rely on this working in the future. We intended make composer prevent installing laravel and lumen at the same time, but never added the restriction. |
Contributor
|
The reason being the global functions conflict with each other and totally screw everything up. |
Contributor
Author
|
@GrahamCampbell I mistakenly thought all the functions were in |
Contributor
|
That would work, yes, and then have the tests conditionally skip on class existance. |
jeskew
force-pushed
the
GrahamCampbell-patch-1
branch
from
a941cf1 to
f6b2bbf
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in #91 and add test for Lumen support.