Refactoring more tests#1435
Merged
kstich merged 1 commit intoaws:masterfrom Dec 11, 2017
carusogabriel:refactoring-tests
Merged
Refactoring more tests#1435kstich merged 1 commit intoaws:masterfrom carusogabriel:refactoring-tests
kstich merged 1 commit intoaws:masterfrom
carusogabriel:refactoring-tests
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
============================================
- Coverage 92.25% 92.22% -0.03%
Complexity 2525 2525
============================================
Files 156 156
Lines 6687 6687
============================================
- Hits 6169 6167 -2
- Misses 518 520 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing to refactory tests, like #1430, I've used:
assertArrayHasKeyandassertArrayNotHasKeyinstead ofissetfunction;assertCountinstead ofcountanditerator_count(PHPUnithandles it)