Skip to content

Comments

Refactoring more tests#1435

Merged
kstich merged 1 commit intoaws:masterfrom
carusogabriel:refactoring-tests
Dec 11, 2017
Merged

Refactoring more tests#1435
kstich merged 1 commit intoaws:masterfrom
carusogabriel:refactoring-tests

Conversation

@carusogabriel
Copy link
Contributor

Continuing to refactory tests, like #1430, I've used:

  • assertArrayHasKey and assertArrayNotHasKey instead of isset function;
  • assertCount instead of count and iterator_count (PHPUnit handles it)

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #1435 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1435      +/-   ##
============================================
- Coverage     92.25%   92.22%   -0.03%     
  Complexity     2525     2525              
============================================
  Files           156      156              
  Lines          6687     6687              
============================================
- Hits           6169     6167       -2     
- Misses          518      520       +2
Impacted Files Coverage Δ Complexity Δ
src/DynamoDb/SetValue.php 80% <0%> (-20%) 5% <0%> (ø)
src/ApiGateway/ApiGatewayClient.php 0% <0%> (ø) 3% <0%> (ø) ⬇️
src/Sdk.php 90% <0%> (ø) 14% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cd58a...76078a2. Read the comment docs.

@kstich kstich merged commit 91deac8 into aws:master Dec 11, 2017
@carusogabriel carusogabriel deleted the refactoring-tests branch December 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants