fix: prevent duplicating metrics middleware#3087
Merged
stobrien89 merged 3 commits intoaws:masterfrom Feb 17, 2025
Merged
Conversation
1 task
- Prevent adding the same metrics middleware multiple times. - Add a hasMiddleware method into HandlerList implementation to check if a middleware was already appended.
e12412d to
f9e42a7
Compare
Contributor
Author
|
stobrien89
requested changes
Feb 17, 2025
Member
stobrien89
left a comment
There was a problem hiding this comment.
Just a doc nit and an extra assertion needed on the test. We need a changelog entry for this as well
- Use added instead of appended to specify when a middleware is added.
- Add change log entry.
stobrien89
approved these changes
Feb 17, 2025
avery-kuo
pushed a commit
to avery-kuo/aws-sdk-php
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3086
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.