fix error with login_credentials when config is enabled #3321
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're invoking the credential provider chain in our production code with no args: ``` Aws::CredentialProviderChain.new.resolve ``` This fails on 176 with a `NameError` when config is enabled: ``` NameError: undefined local variable or method `region' for #<Aws::CredentialProviderChain:0x00000001094dc100 @config=nil> aws-sdk-core-3.239.1/lib/aws-sdk-core/credential_provider_chain.rb:176:in `login_credentials' aws-sdk-core-3.239.1/lib/aws-sdk-core/credential_provider_chain.rb:13:in `block in resolve' aws-sdk-core-3.239.1/lib/aws-sdk-core/credential_provider_chain.rb:12:in `each' aws-sdk-core-3.239.1/lib/aws-sdk-core/credential_provider_chain.rb:12:in `resolve' ``` PR aws#3319[^1] inadvertently caused this error by not checking if config was passed. Elsewhere in the file the code is guarding against that. Write a failing test, then make it pass. [^1]: aws#3319
Contributor
|
Really sorry you're hitting this issue. We didn't expect changes to an api private class to have this kind of ripple effect, but myself and @richardwang1124 will be taking a look today. Thank you for your patience. |
richardwang1124
approved these changes
Nov 25, 2025
Contributor
|
Hey all, sorry for breaking your workflow with this change. You are correct, config should be checked first before extracting the region. I've approved the PR and will merge it for today's release. Thank you for your patience! |
richardwang1124
referenced
this pull request
Nov 25, 2025
jterapin
approved these changes
Nov 25, 2025
Contributor
jterapin
left a comment
jterapin
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're invoking the credential provider chain in our production code with no args:
This fails on 176 with a
NameErrorwhen config is enabled:PR #33191 inadvertently caused this error by not checking if config was passed. Elsewhere in the file the code is guarding against that.
Write a failing test, then make it pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!
Footnotes
https://github.com/aws/aws-sdk-ruby/pull/3319 ↩