Skip to content

Fix TTL error message to reflect valid range 0-3600#167

Merged
harsheejshah merged 1 commit into
aws:mainfrom
vaibhav61:fix/ttl-error-message
Feb 20, 2026
Merged

Fix TTL error message to reflect valid range 0-3600#167
harsheejshah merged 1 commit into
aws:mainfrom
vaibhav61:fix/ttl-error-message

Conversation

@vaibhav61
Copy link
Copy Markdown
Contributor

Issue #, if available: N/A

Description of changes:

The INVALID_TTL_SECONDS_ERR_MSG in constants.rs states the valid TTL range is "1 to 3600", but the actual validation in config.rs uses Some(0..3601), which accepts 0 as a valid value. A TTL of 0 disables caching, as documented in the README ("0 indicates that there is no caching"). This change updates the error message from "1 to 3600" to "0 to 3600" to accurately reflect the accepted range.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vaibhav61 vaibhav61 requested a review from a team as a code owner February 14, 2026 00:34
Copy link
Copy Markdown
Contributor

@simonmarty simonmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice catch.

@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Feb 14, 2026
@github-actions github-actions Bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Feb 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.14%. Comparing base (e425e69) to head (61d381f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          14       14           
  Lines        2405     2405           
  Branches     2405     2405           
=======================================
  Hits         2216     2216           
  Misses        143      143           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harsheejshah harsheejshah merged commit b2a5dd0 into aws:main Feb 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants