Revert file-based credential support#201
Merged
Merged
Conversation
lohdipak
approved these changes
May 8, 2026
lohdipak
previously approved these changes
May 8, 2026
derik01
previously approved these changes
May 8, 2026
This reverts commit 362365c.
3db44b9 to
b2bb0aa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 92.34% 92.14% -0.21%
==========================================
Files 15 14 -1
Lines 2626 2405 -221
Branches 2626 2405 -221
==========================================
- Hits 2425 2216 -209
+ Misses 152 143 -9
+ Partials 49 46 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Secrets Manager Agent Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: b2bb0aa | Previous: 3db44b9 | Ratio |
|---|---|---|---|
CacheEviction |
100610 ns/iter (± 16437) |
59879 ns/iter (± 7240) |
1.68 |
This comment was automatically generated by workflow using github-action-benchmark.
derik01
approved these changes
May 11, 2026
simonmarty
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit 362365c (PR #192).