Skip to content

Revert file-based credential support#201

Merged
simonmarty merged 1 commit into
mainfrom
revert-file-based-creds
May 11, 2026
Merged

Revert file-based credential support#201
simonmarty merged 1 commit into
mainfrom
revert-file-based-creds

Conversation

@reyhankoyun
Copy link
Copy Markdown
Contributor

@reyhankoyun reyhankoyun commented May 8, 2026

Reverts commit 362365c (PR #192).

@reyhankoyun reyhankoyun requested a review from a team as a code owner May 8, 2026 20:34
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label May 8, 2026
lohdipak
lohdipak previously approved these changes May 8, 2026
derik01
derik01 previously approved these changes May 8, 2026
@reyhankoyun reyhankoyun enabled auto-merge (squash) May 8, 2026 20:44
@github-actions github-actions Bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label May 8, 2026
@reyhankoyun reyhankoyun dismissed stale reviews from derik01 and lohdipak via b2bb0aa May 8, 2026 21:00
@reyhankoyun reyhankoyun force-pushed the revert-file-based-creds branch from 3db44b9 to b2bb0aa Compare May 8, 2026 21:00
@reyhankoyun reyhankoyun added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.14%. Comparing base (c04d410) to head (b2bb0aa).

Files with missing lines Patch % Lines
aws_secretsmanager_agent/src/cache_manager.rs 66.66% 0 Missing and 1 partial ⚠️
aws_secretsmanager_agent/src/config.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   92.34%   92.14%   -0.21%     
==========================================
  Files          15       14       -1     
  Lines        2626     2405     -221     
  Branches     2626     2405     -221     
==========================================
- Hits         2425     2216     -209     
+ Misses        152      143       -9     
+ Partials       49       46       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Secrets Manager Agent Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: b2bb0aa Previous: 3db44b9 Ratio
CacheEviction 100610 ns/iter (± 16437) 59879 ns/iter (± 7240) 1.68

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label May 8, 2026
@simonmarty simonmarty disabled auto-merge May 11, 2026 17:42
@simonmarty simonmarty merged commit fda3e15 into main May 11, 2026
9 of 12 checks passed
@simonmarty simonmarty deleted the revert-file-based-creds branch May 11, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants