Skip to content

Conversation

@bhouse99
Copy link
Contributor

Updated to support AWS SDK 2 to better support later systems.

Created tag marking AWS SDK 1 dependency in case this causes
a down stream issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updated to support AWS SDK 2 to better support later systems.

Created tag marking AWS SDK 1 dependency incase this causes
a down stream issue.
Copy link
Contributor

@dchenbec dchenbec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a minor nit

Updated a missed point in the configuration documentation
Copy link
Contributor

@dchenbec dchenbec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bhouse99 bhouse99 merged commit fdabb69 into aws:master Jan 20, 2021
@DieterVDW
Copy link

DieterVDW commented Mar 16, 2022

Retro-active remark: switching a core library (AWS SDK) from V1 to V2 is not a minor version change.
This has pretty drastic effects on the dependency management of projects using this library, and that is not expected when updating a minor version of a library.
Caused a bit of trouble over here, however thank your for your efforts in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants