Skip to content

Conversation

@hunterwerlla
Copy link
Contributor

@hunterwerlla hunterwerlla commented May 29, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Added tests
  • Code cleanup

Description

Motivation and Context

Related Issue(s), If Filed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • Local run of npm run fullBuild succeeds
  • I have run tslint against my changes using the root tslint.yaml
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG (CHANGELOG.md) if the change is feature related

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

screenshot

Screen Shot 2019-05-30 at 09 26 33

@hunterwerlla hunterwerlla requested a review from awschristou May 29, 2019 23:15
@hunterwerlla hunterwerlla requested a review from a team as a code owner May 29, 2019 23:15
@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   31.58%   31.58%           
=======================================
  Files          57       57           
  Lines        2150     2150           
  Branches      294      294           
=======================================
  Hits          679      679           
  Misses       1470     1470           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb0b98...a0a2f28. Read the comment docs.

@hunterwerlla hunterwerlla merged commit 8f67d13 into master May 30, 2019
@hunterwerlla hunterwerlla deleted the werlla/icons branch May 30, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants