Fix #220, normalize task names/descriptions to have both the long and short name in all cases #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awschristou
approved these changes
Jun 6, 2019
| "name": "CloudFormationDeleteStack", | ||
| "friendlyName": "AWS CloudFormation Delete Stack", | ||
| "description": "Deletes an AWS CloudFormation stack.", | ||
| "description": "Deletes a AWS CloudFormation stack.", |
There was a problem hiding this comment.
The changes to "a AWS" in this PR seem odd to me.
Contributor
Author
There was a problem hiding this comment.
I got a little to excited about a vs an, reverted this change (and looking over the other changes)
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 45.81% 45.81%
=======================================
Files 49 49
Lines 1936 1936
Branches 280 280
=======================================
Hits 887 887
Misses 1047 1047
Partials 2 2Continue to review full report at Codecov.
|
…erlla/normalizeTaskNames
…erlla/normalizeTaskNames
awschristou
reviewed
Jun 7, 2019
Tasks/LambdaInvokeFunction/task.json
Outdated
| "name": "LambdaInvokeFunction", | ||
| "friendlyName": "AWS Lambda Invoke Function", | ||
| "description": "Invokes a AWS Lambda function", | ||
| "description": "Invokes a Lambda function", |
…erlla/normalizeTaskNames
…s-vsts-tools into werlla/normalizeTaskNames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Motivation and Context
Related Issue(s), If Filed
fix #220
Testing
Checklist
npm run fullBuildsucceedsLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.