Merged
Conversation
The name was a bit confusing when it showed up in a stack trace since the error has nothing to do with decimals.
kyleknap
approved these changes
May 6, 2019
Contributor
kyleknap
left a comment
kyleknap
left a comment
There was a problem hiding this comment.
Looks good. Should be good to merge once the build passes. 🚢
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
+ Coverage 95.48% 95.52% +0.04%
==========================================
Files 27 27
Lines 4581 4581
Branches 578 578
==========================================
+ Hits 4374 4376 +2
+ Misses 135 134 -1
+ Partials 72 71 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on #1100