Skip to content

Set minimumCompressionSize before API gateway stage is deployed#1172

Closed
topu wants to merge 1 commit intoaws:masterfrom
topu:fix-minimumCompressionSize
Closed

Set minimumCompressionSize before API gateway stage is deployed#1172
topu wants to merge 1 commit intoaws:masterfrom
topu:fix-minimumCompressionSize

Conversation

@topu
Copy link

@topu topu commented Jul 12, 2019

Description of changes:
This makes setting minimumCompressionSize happen before API Gateway stage is deployed and fixes #1171.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #1172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          27       27           
  Lines        4657     4657           
  Branches      588      588           
=======================================
  Hits         4450     4450           
  Misses        136      136           
  Partials       71       71
Impacted Files Coverage Δ
chalice/deploy/planner.py 96.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ac9c5...bc32ba7. Read the comment docs.

@kapilt
Copy link
Contributor

kapilt commented Jul 20, 2019

fwiw, #1160 also ends up doing this albeit for a different reason.

@jamesls
Copy link
Member

jamesls commented Aug 8, 2019

#1160 has been merged, closing.

@jamesls jamesls closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minimumCompressionSize is not applied until API Gateway stage is deployed

4 participants