add support for lambda invoke role in CustomAuthorizer#1303
Closed
fortzi wants to merge 1 commit intoaws:masterfrom
Closed
add support for lambda invoke role in CustomAuthorizer#1303fortzi wants to merge 1 commit intoaws:masterfrom
fortzi wants to merge 1 commit intoaws:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
+ Coverage 96.19% 96.19% +<.01%
==========================================
Files 28 28
Lines 5288 5289 +1
Branches 675 675
==========================================
+ Hits 5087 5088 +1
Misses 130 130
Partials 71 71
Continue to review full report at Codecov.
|
Member
|
Thanks for the pull request! I pulled your changes and made a few minor adjustments, but otherwise looks good! I didn't want to push to your master branch so I opened a new PR here #1364. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
CustomAuthorizercan now be set with a Lambda Invoke Role via theinvoke_role_arnargument.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.