Skip to content

add support for lambda invoke role in CustomAuthorizer#1303

Closed
fortzi wants to merge 1 commit intoaws:masterfrom
fortzi:master
Closed

add support for lambda invoke role in CustomAuthorizer#1303
fortzi wants to merge 1 commit intoaws:masterfrom
fortzi:master

Conversation

@fortzi
Copy link

@fortzi fortzi commented Nov 17, 2019

Description of changes:
CustomAuthorizer can now be set with a Lambda Invoke Role via the invoke_role_arn argument.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #1303 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   96.19%   96.19%   +<.01%     
==========================================
  Files          28       28              
  Lines        5288     5289       +1     
  Branches      675      675              
==========================================
+ Hits         5087     5088       +1     
  Misses        130      130              
  Partials       71       71
Impacted Files Coverage Δ
chalice/app.py 97.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a1eee...0576aaa. Read the comment docs.

@jamesls
Copy link
Member

jamesls commented Feb 25, 2020

Thanks for the pull request! I pulled your changes and made a few minor adjustments, but otherwise looks good! I didn't want to push to your master branch so I opened a new PR here #1364. Thanks again!

@jamesls jamesls closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants