Skip to content

Fix new lines on rendered changelog#2107

Merged
jamesls merged 1 commit into
aws:masterfrom
jamesls:fix-changelog-render
May 30, 2024
Merged

Fix new lines on rendered changelog#2107
jamesls merged 1 commit into
aws:masterfrom
jamesls:fix-changelog-render

Conversation

@jamesls
Copy link
Copy Markdown
Member

@jamesls jamesls commented May 29, 2024

This issue was introduced in the latest release (1.31.1) which pulled in the latest version of jmeslog which changed the default template being used. We now use an explicit template to control against this.

As part of this change I switched the template over to markdown. This lets all the recent changelog links to issues/PRs get properly linked (they weren't being rendered as links in restructured text).

As part of this change I switched the template over to markdown.  This
lets all the recent changelog links to issues/PRs get properly linked
(they weren't being rendered as links in restructured text).

This issue was introduced in the latest release which pulled in the
latest version of jmeslog which changed the default template being used.
We now use an explicit template to control against this.
@jamesls jamesls requested a review from SamRemis May 29, 2024 21:52
Copy link
Copy Markdown
Contributor

@adityamohta adityamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jamesls
Copy link
Copy Markdown
Member Author

jamesls commented May 30, 2024

Failure is because the switch to CHANGELOG.md isn't merged yet so this is an expected failure:

Warning, treated as error:
/home/runner/work/chalice/chalice/docs/source/upgrading.rst:4:broken link: https://github.com/aws/chalice/blob/master/CHANGELOG.md (404 Client Error: Not Found for url: https://github.com/aws/chalice/blob/master/CHANGELOG.md)

@jamesls jamesls merged commit f3cec7f into aws:master May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants