Fix handling of trailing slash to match API Gateway#588
Closed
stealthycoin wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 94.68% 94.69% +0.01%
==========================================
Files 18 18
Lines 3179 3185 +6
Branches 413 414 +1
==========================================
+ Hits 3010 3016 +6
Misses 118 118
Partials 51 51
Continue to review full report at Codecov.
|
stealthycoin
force-pushed
the
local-trailing-slash
branch
3 times, most recently
from
fa7ff96 to
cbda2fd
Compare
API Gateway will not match a URI against a route that has a capture
group as the last path component if that capture group would be filled
with an empty string. Example:
With the route:
/resource/{name}
/resource/bob matches
/resource/ does not match
Previously local mode would match both URIs to that route, setting the
name parameter to an empty string.
closes aws#582
This change also prvents `chalice local` from running if there is a
route that ends with a / since `chalice deploy` will not let you deploy
such routes.
stealthycoin
force-pushed
the
local-trailing-slash
branch
from
cbda2fd to
a50e33d
Compare
Member
|
Looks good, I'm just going to add another test. I want a test that verifies if you have I'll also go ahead and rebase on master. |
jamesls
approved these changes
Nov 16, 2017
jamesls
added a commit
that referenced
this pull request
Nov 16, 2017
PR #588 * stealthycoin-local-trailing-slash: Update test with latest changes from master Add additional test for trailing slash Fix handling of trailing slash to match API Gateway
Member
|
Merged in bd05f56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Gateway will not match a URI against a route that has a capture
group as the last path component if that capture group would be filled
with an empty string. Example:
With the route:
/resource/{name}
/resource/bob matches
/resource/ does not match
Previously local mode would match both URIs to that route, setting the
name parameter to an empty string.
closes #582