Merged
Conversation
stealthycoin
requested review from
JordonPhillips,
dstufft,
jamesls and
kyleknap
dstufft
reviewed
Jul 30, 2018
dstufft
left a comment
dstufft
left a comment
There was a problem hiding this comment.
Looks fine to me, the relevant pip issue is pypa/pip#988.
| mock==2.0.0 | ||
| requests==2.18.4 | ||
| hypothesis==3.56.3 | ||
| pluggy<0.7 |
There was a problem hiding this comment.
I would add a comment about why this dependency is being added here, since it's not really a direct dependency and it's likely in N months we'll forget why it's here.
Pluggy released 0.7.0 and 0.7.1 and the way pip does dependency resolution it doesn't catch that pytest requires < 0.7. Hoisting the requirement of <0.7 up to the top of requirements-dev.txt allows pip to pull in the correct version of pluggy which is 0.6.0.
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 27 27
Lines 4449 4449
Branches 558 558
=======================================
Hits 4250 4250
Misses 128 128
Partials 71 71Continue to review full report at Codecov.
|
dstufft
approved these changes
Jul 30, 2018
JordonPhillips
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pluggy released 0.7.0 and 0.7.1and the way pip does dependency
resolution it doesn't catch that pytest requires < 0.7. Hoisting the
requirement of <0.7 up to the top of requirements-dev.txt allows pip to
pull in the correct version of pluggy which is 0.6.0.