generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 17
Add SageMaker Code Editor version mapping to release workflow #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+119
−48
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f946ce
Map between the Code Editor and SageMaker Code Editor versions only i…
47d6328
automatically create tag when release workflow triggered
cf44d7e
update release information
71b2335
patches to show both versions in about dialog
f08b377
improve release description formatting
a5bcdbb
moving back to correct codeoss src version
aa3d3e6
adding sagemakercodeeditorversion placeholder in product json
246d769
Fixed bug
vpaiu d3457c8
Remove code editor version in about section
vpaiu 50501b9
Merge branch '1.0' into 1.0
vpaiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| Index: code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts | ||
| =================================================================== | ||
| --- code-editor-src.orig/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts | ||
| +++ code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts | ||
| @@ -79,8 +79,8 @@ export class BrowserDialogHandler extend | ||
| async about(): Promise<void> { | ||
| const detailString = (useAgo: boolean): string => { | ||
| return localize('aboutDetail', | ||
| - "Code Editor Version: {0}\nCode - OSS Version: {1}\nDate: {2}\nBrowser: {3}", | ||
| - this.productService.codeEditorVersion || 'Unknown', | ||
| + "SageMaker Code Editor Version: {0}\nCode - OSS Version: {1}\nDate: {2}\nBrowser: {3}", | ||
| + this.productService.sagemakerCodeEditorVersion || 'Unknown', | ||
| this.productService.version || 'Unknown', | ||
| this.productService.date ? `${this.productService.date}${useAgo ? ' (' + fromNow(new Date(this.productService.date), true) + ')' : ''}` : 'Unknown', | ||
| navigator.userAgent | ||
| Index: code-editor-src/src/vs/base/common/product.ts | ||
| =================================================================== | ||
| --- code-editor-src.orig/src/vs/base/common/product.ts | ||
| +++ code-editor-src/src/vs/base/common/product.ts | ||
| @@ -62,6 +62,7 @@ export interface IProductConfiguration { | ||
| readonly quality?: string; | ||
| readonly commit?: string; | ||
| readonly codeEditorVersion?: string; | ||
| + readonly sagemakerCodeEditorVersion?: string; | ||
|
|
||
| readonly nameShort: string; | ||
| readonly nameLong: string; | ||
| Index: code-editor-src/product.json | ||
| =================================================================== | ||
| --- code-editor-src.orig/product.json | ||
| +++ code-editor-src/product.json | ||
| @@ -12,6 +12,7 @@ | ||
| "nameShort": "SageMaker Code Editor", | ||
| "nameLong": "SageMaker Code Editor", | ||
| "codeEditorVersion": "1.0.0", | ||
| + "sagemakerCodeEditorVersion":"1.0.0", | ||
| "applicationName": "code", | ||
| "dataFolderName": ".vscode-editor", | ||
| "win32MutexName": "vscodeoss", | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the filename does not match the updated purpose of the patch.