Skip to content

fix: prefix unused context param with underscore in post-startup-noti…#267

Merged
chunqilu merged 1 commit into
1.2from
dev/1.2-fix-build-error
Jul 3, 2026
Merged

fix: prefix unused context param with underscore in post-startup-noti…#267
chunqilu merged 1 commit into
1.2from
dev/1.2-fix-build-error

Conversation

@chunqilu

@chunqilu chunqilu commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

…fications

Issue

target build failed in https://github.com/aws/code-editor/actions/runs/28651915757/job/84971750002 with error

Error: [09:39:56] extensions/post-startup-notifications/src/extension.ts(11,26): error TS6133: 'context' is declared but its value is never read.
Error: Process completed with exit code 1.

Description of Changes

The change is to prefix unused context param with underscore to pass compiling check.

Testing

test build passed https://github.com/aws/code-editor/actions/runs/28655470049

Screenshots/Videos

Additional Notes

Backporting


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chunqilu chunqilu requested review from a team as code owners July 3, 2026 11:03
@chunqilu chunqilu enabled auto-merge July 3, 2026 11:11
@chunqilu chunqilu added this pull request to the merge queue Jul 3, 2026
Merged via the queue into 1.2 with commit 02964b2 Jul 3, 2026
4 of 5 checks passed
@chunqilu chunqilu deleted the dev/1.2-fix-build-error branch July 3, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants