feat(templates): enable deployment circuit breaker for services #1838
feat(templates): enable deployment circuit breaker for services #1838mergify[bot] merged 2 commits intoaws:mainlinefrom
Conversation
iamhopaul123
left a comment
There was a problem hiding this comment.
LGTM! Do we need to update integ test for this change?
|
I checked and didn't seee anything that might break them, but I guess we'll see :D I'll monitor the pipeline |
|
@efekarakus We found there to be some issues with the way cloudformation interacts with the circuit breaker (aws/containers-roadmap#1205) outside of copilot. Does copilot deal with this better somehow? |
|
Hey @mwarkentin ! Copilot v1.2.0 will display deployment progress while running Screen.Recording.2021-01-22.at.10.01.03.AM.movUnfortunately, the resource status will still be |
|
@efekarakus thanks - so basically you highlight what's going on, but the user needs to take some action to get things back to working order (or in sync). |
|
Yeah, unfortunately that's right |
|
No worries! 🤞 that the cloudformation integration improves at some point! |
Resolves #1735
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.