Skip to content

feat(templates): enable deployment circuit breaker for services #1838

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
efekarakus:enable-circuit-breaker
Jan 15, 2021
Merged

feat(templates): enable deployment circuit breaker for services #1838
mergify[bot] merged 2 commits intoaws:mainlinefrom
efekarakus:enable-circuit-breaker

Conversation

@efekarakus
Copy link
Copy Markdown
Contributor

Resolves #1735

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@efekarakus efekarakus requested a review from a team as a code owner January 15, 2021 01:08
@mergify mergify Bot merged commit 007be21 into aws:mainline Jan 15, 2021
Copy link
Copy Markdown
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we need to update integ test for this change?

@efekarakus efekarakus deleted the enable-circuit-breaker branch January 15, 2021 01:25
@efekarakus
Copy link
Copy Markdown
Contributor Author

I checked and didn't seee anything that might break them, but I guess we'll see :D I'll monitor the pipeline

@mwarkentin
Copy link
Copy Markdown

@efekarakus We found there to be some issues with the way cloudformation interacts with the circuit breaker (aws/containers-roadmap#1205) outside of copilot. Does copilot deal with this better somehow?

@efekarakus
Copy link
Copy Markdown
Contributor Author

efekarakus commented Feb 1, 2021

Hey @mwarkentin ! Copilot v1.2.0 will display deployment progress while running copilot deploy, so you'll be able to tell that your service actually rolled back due to the circuit breaker kicking in:

Screen.Recording.2021-01-22.at.10.01.03.AM.mov

Unfortunately, the resource status will still be UPDATE_COMPLETE in CloudFormation. It's just that Copilot won't exit immediately unlike CFN and will keep monitoring the deployment rollout status until the rollout state is no longer in progress.

@mwarkentin
Copy link
Copy Markdown

@efekarakus thanks - so basically you highlight what's going on, but the user needs to take some action to get things back to working order (or in sync).

@efekarakus
Copy link
Copy Markdown
Contributor Author

Yeah, unfortunately that's right

@mwarkentin
Copy link
Copy Markdown

No worries! 🤞 that the cloudformation integration improves at some point!

thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
…1838)

Resolves aws#1735 

_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circuit breaker support

6 participants