chore: improve debugging for no subnets error in task run#2023
Closed
ota42y wants to merge 4 commits intoaws:mainlinefrom
Closed
chore: improve debugging for no subnets error in task run#2023ota42y wants to merge 4 commits intoaws:mainlinefrom
ota42y wants to merge 4 commits intoaws:mainlinefrom
Conversation
ota42y
changed the title
ota42y
changed the title
ota42y
force-pushed
the
feature/add_subnets_error_message
branch
from
b162291 to
ee77888
Compare
efekarakus
reviewed
Mar 8, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Awesome thank you so much for making debugging this issue better 🙇 ! Some small suggestions below
efekarakus
changed the title
Contributor
Author
|
I have completed the fix! |
efekarakus
added
the
do-not-merge
efekarakus
approved these changes
Mar 9, 2021
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Yay this looks great! Thank you so much, I left some small nits. Once addressed, we'll remove the "do-not-merge" label which will make @mergifyio automatically merge your PR 🚀
Comment on lines
11
to
+12
| var ( | ||
| errNoSubnetFound = errors.New("no subnets found") | ||
| ErrNoSubnetFound = errors.New("no subnets found") |
Contributor
There was a problem hiding this comment.
Can we add a top-level comment here since we now have exported errors
Suggested change
| var ( | |
| errNoSubnetFound = errors.New("no subnets found") | |
| ErrNoSubnetFound = errors.New("no subnets found") | |
| // Errors returned while trying to run a task. | |
| var ( | |
| ErrNoSubnetFound = errors.New("no subnets found") |
Co-authored-by: Efe Karakus <efekarakus@gmail.com>
Contributor
Author
Contributor
|
Yay sounds good! We'll merge #2024 instead! |
Contributor
Author
|
Ok, I'm going to close this PR when #2024 merged |
Contributor
Author
|
#2024 is merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error message to let users know that a tag is required for subnet to run task.
Please read this issue
#2022