feat(cli): allow to reject any ssm plugin install/update#2060
Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom Mar 16, 2021
Merged
feat(cli): allow to reject any ssm plugin install/update#2060mergify[bot] merged 2 commits intoaws:mainlinefrom
mergify[bot] merged 2 commits intoaws:mainlinefrom
Conversation
Contributor
Author
|
huanjani
reviewed
Mar 16, 2021
| taskID string | ||
| containerName string | ||
| skipConfirmation bool | ||
| yes *bool |
Contributor
There was a problem hiding this comment.
I wonder if we should make this flag more descriptive, like ssmPlugin or updateSSM or something?
Contributor
There was a problem hiding this comment.
Do we need the new yes field? (see below) I think we can get away by making this a pointer and assigning a local variable instead of storing this as a field in the struct
Suggested change
| yes *bool | |
| skipConfirmation *bool // If nil, we will prompt to upgrade the ssm plugin. |
efekarakus
reviewed
Mar 16, 2021
| taskID string | ||
| containerName string | ||
| skipConfirmation bool | ||
| yes *bool |
Contributor
There was a problem hiding this comment.
Do we need the new yes field? (see below) I think we can get away by making this a pointer and assigning a local variable instead of storing this as a field in the struct
Suggested change
| yes *bool | |
| skipConfirmation *bool // If nil, we will prompt to upgrade the ssm plugin. |
efekarakus
approved these changes
Mar 16, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> This PR makes it possible to reject any SSM plugin install/update with `--yes=false`. Technically not many users want to use this feature. It is mainly for the e2e tests so that we can skip without updating the SSM plugin. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to reject any SSM plugin install/update with
--yes=false. Technically not many users want to use this feature. It is mainly for the e2e tests so that we can skip without updating the SSM plugin.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.