fix: bump all Lambda nodejs runtimes to 12.x#2237
Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom Apr 29, 2021
Merged
Conversation
Lambda is on the path to deprecate nodejs10.x, bumping the runtime version to the latest 14.x Resolves aws#2235
efekarakus
commented
Apr 29, 2021
| # SPDX-License-Identifier: Apache-2.0 | ||
| Description: CloudFormation environment template for infrastructure shared among Copilot workloads. | ||
| Metadata: | ||
| Version: 'v1.3.1' |
Contributor
Author
There was a problem hiding this comment.
There is no difference in this template besides the version here, we had to create a new version so that the Lambda runtime version updates can be picked up by env upgrade
efekarakus
added
the
do-not-merge
Contributor
Author
|
Welp I just tried deploying with Autoscaling and get this error 😭 :
I'm going try to change all the Lambdas to nodejs12.x and see if |
efekarakus
removed
the
do-not-merge
efekarakus
changed the title
bvtujo
approved these changes
Apr 29, 2021
iamhopaul123
approved these changes
Apr 29, 2021
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
Lambda is on the path to deprecate nodejs10.x, bumping the runtime version to 12.x. Tested by deploying an application with copilotv1.5 and then deployed the service again: - [x] the environment gets upgraded to v1.3.1 - [x] service deployment is successful Resolves aws#2235 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lambda is on the path to deprecate nodejs10.x, bumping the runtime version to 12.x.
Tested by deploying an application with copilotv1.5 and then deployed the service again:
Resolves #2235
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.