fix: stop truncating logs to 10 at a time when running svc logs --follow#3258
Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom Feb 9, 2022
Merged
fix: stop truncating logs to 10 at a time when running svc logs --follow#3258mergify[bot] merged 3 commits intoaws:mainlinefrom
svc logs --follow#3258mergify[bot] merged 3 commits intoaws:mainlinefrom
Conversation
Lou1415926
approved these changes
Feb 9, 2022
| } | ||
| if o.Follow { | ||
| // Start following log events from current timestamp. | ||
| return aws.Int64(now().Unix() * 1000) // Multiplied by 1000 to convert the Unix() timestamp in seconds to milliseconds |
Contributor
There was a problem hiding this comment.
nit: or alternatively...
Suggested change
| return aws.Int64(now().Unix() * 1000) // Multiplied by 1000 to convert the Unix() timestamp in seconds to milliseconds | |
| return aws.Int64(now().UnixMilli()) |
Contributor
Author
There was a problem hiding this comment.
wow I had no idea this method existed 😂 fixed!
I also changed it in other places in the codebase where we multiplied by 1000
huanjani
reviewed
Feb 9, 2022
| mockDefaultLimit := aws.Int64(10) | ||
| var mockNilLimit *int64 | ||
| mockStartTime := aws.Int64(123456789) | ||
| mockCurrentTimestamp := time.Date(2020, 11, 23, 0, 0, 0, 0, time.UTC) // Copilot GA date :). |
iamhopaul123
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3220
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.