Skip to content

Conversation

@dannyrandall
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@dannyrandall dannyrandall requested a review from a team as a code owner April 1, 2022 17:29
@dannyrandall dannyrandall requested review from efekarakus and removed request for a team April 1, 2022 17:29
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huanjani huanjani added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Apr 2, 2022
pipelineResourcesFlagDescription = "Optional. Show the resources in your pipeline."
localSvcFlagDescription = "Only show services in the workspace."
localJobFlagDescription = "Only show jobs in the workspace."
localPipelineFlagDescription = "Only show pipelines in the workspace."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is (correctly) consistent with the other --local flags, but just a note to ourselves that we should go through all of the flags to make sure we include "Optional" where should.

@efekarakus efekarakus changed the title chore(pipelines): pipelines ls --local flag support feat(pipelines): pipelines ls --local flag support Apr 5, 2022
@dannyrandall dannyrandall requested a review from huanjani April 5, 2022 20:40
dannyrandall and others added 3 commits April 5, 2022 14:27
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
@iamhopaul123 iamhopaul123 self-requested a review April 5, 2022 22:20
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dannyrandall dannyrandall removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Apr 5, 2022
@mergify mergify bot merged commit 5002f11 into aws:mainline Apr 5, 2022
@dannyrandall dannyrandall deleted the chore/pipelines-ls-local branch April 5, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants