Skip to content

fix: force env action when deploying service with updated environment#3957

Merged
mergify[bot] merged 12 commits intoaws:mainlinefrom
dannyrandall:fix/force-env-action
Aug 30, 2022
Merged

fix: force env action when deploying service with updated environment#3957
mergify[bot] merged 12 commits intoaws:mainlinefrom
dannyrandall:fix/force-env-action

Conversation

@dannyrandall
Copy link
Copy Markdown
Contributor

Fixes #3931

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@dannyrandall dannyrandall requested a review from a team as a code owner August 26, 2022 21:37
@dannyrandall dannyrandall requested review from Lou1415926 and removed request for a team August 26, 2022 21:37
Copy link
Copy Markdown
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution to a gnarly problem!

@Lou1415926 Lou1415926 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 29, 2022
@dannyrandall dannyrandall marked this pull request as draft August 29, 2022 20:58
@dannyrandall dannyrandall changed the title fix: force env action when deploying service with updated copilot version fix: force env action when deploying service with updated environment Aug 29, 2022
@dannyrandall dannyrandall marked this pull request as ready for review August 29, 2022 22:10
@dannyrandall dannyrandall requested a review from huanjani August 29, 2022 22:11
Comment thread internal/pkg/template/templates/workloads/partials/cf/env-controller.yml Outdated
Comment thread cf-custom-resources/lib/env-controller.js
Comment thread internal/pkg/cli/svc_package.go Outdated
Comment thread internal/pkg/cli/svc_deploy_test.go Outdated
Comment thread internal/pkg/deploy/cloudformation/stack/testdata/workloads/rdws-test.stack.yml Outdated
@dannyrandall dannyrandall removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 30, 2022
@mergify mergify Bot merged commit db41259 into aws:mainline Aug 30, 2022
@dannyrandall dannyrandall deleted the fix/force-env-action branch August 30, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to upgrade a Backend Service from 1.19 to 1.21

4 participants