Skip to content

chore: env manager patcher and service discovery namespace should work with bootstrap stack#3966

Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom
Lou1415926:fix/bootstrap-stack-bugs
Aug 30, 2022
Merged

chore: env manager patcher and service discovery namespace should work with bootstrap stack#3966
mergify[bot] merged 3 commits intoaws:mainlinefrom
Lou1415926:fix/bootstrap-stack-bugs

Conversation

@Lou1415926
Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 commented Aug 30, 2022

Previously, we have two fixes:

  1. fix: ensure env manager role has permission to upload #3956 which patches the S3 permissions to the environment manager role if it's needed.
  2. fix: preserve existing service discovery endpoint #3949 which preserves service discovery endpoint namespace from a previously deployed env stack.

Fix 1 performs an environment template version check to infer whether the necessary permissions are present. This version check fails to take into account the "bootstrap" version, which is present when the environment is only bootstrapped (by running env init and not having run env deploy)

Fix 2 grabs the old parameter from a deployed environment stack. It fails to take into consideration that, while an env stack that's on "bootstrap" version is not considered a "deployed environment" in Copilot, it is a deployed stack in CFN.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926 Lou1415926 requested a review from a team as a code owner August 30, 2022 22:35
@Lou1415926 Lou1415926 requested review from dannyrandall and removed request for a team August 30, 2022 22:35
Comment thread internal/pkg/deploy/cloudformation/env.go Outdated
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I hadn't realized previously that we were using "boostrap" for version! 😄

@mergify mergify Bot merged commit a830133 into aws:mainline Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants