feat: add http.redirect_to_https field to service manifest#4003
Merged
mergify[bot] merged 27 commits intoaws:mainlinefrom Sep 20, 2022
Merged
feat: add http.redirect_to_https field to service manifest#4003mergify[bot] merged 27 commits intoaws:mainlinefrom
http.redirect_to_https field to service manifest#4003mergify[bot] merged 27 commits intoaws:mainlinefrom
Conversation
dannyrandall
requested review from
efekarakus
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## mainline #4003 +/- ##
============================================
+ Coverage 68.65% 68.69% +0.03%
============================================
Files 248 248
Lines 35067 35085 +18
Branches 264 264
============================================
+ Hits 24076 24100 +24
+ Misses 9801 9797 -4
+ Partials 1190 1188 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Parag Sanjay Bhingre <paragbhingre@gmail.com>
iamhopaul123
approved these changes
Sep 19, 2022
dannyrandall
changed the title
http.redirect field to service manifesthttp.disable_redirect field to service manifest
dannyrandall
changed the title
http.disable_redirect field to service manifesthttp.redirect_to_https field to service manifest
efekarakus
approved these changes
Sep 20, 2022
| {{- end}} | ||
| Conditions: | ||
| {{- if .Aliases }} | ||
| {{- if .AllowedSourceIps}} |
Contributor
Author
There was a problem hiding this comment.
"bug" fix, yeah :)
| Secrets: convertSecrets(s.manifest.BackendServiceConfig.Secrets), | ||
| Aliases: aliases, | ||
| HTTPSListener: s.httpsEnabled, | ||
| HTTPRedirect: s.httpsEnabled, |
Contributor
There was a problem hiding this comment.
gotcha, so we're only supporting this field for now for LBWS as there is no need of a cdn for internal ALBs 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the ability to disable the ALB redirect from http -> https when using a custom domain.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.