fix: allow unseting GracePeriod when default value is provided#4015
Merged
mergify[bot] merged 1 commit intoaws:mainlinefrom Sep 23, 2022
Merged
Conversation
efekarakus
requested review from
KollaAdithya
and removed request for
a team
Lou1415926
reviewed
Sep 21, 2022
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
If user wants to add http to a backend service, they'd need a two-step deployment:
- Enable
httpwithgrace_periods: 0s - Change
grace_periodsto whatever value they actually want
Is this understanding correct?
Contributor
Author
Yes that is correct, it's currently a bug in ECS that the scheduler team is aware of 👍 |
Lou1415926
approved these changes
Sep 21, 2022
iamhopaul123
approved these changes
Sep 22, 2022
efekarakus
force-pushed
the
fix/allow-disabling-grace-period
branch
from
5a0733e to
56bc3c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort of fixes #4011
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.