Skip to content

docs: add link to a proper aws guide for configuring credentials#4091

Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom
genbit:docs-credentials
Jan 18, 2023
Merged

docs: add link to a proper aws guide for configuring credentials#4091
mergify[bot] merged 5 commits intoaws:mainlinefrom
genbit:docs-credentials

Conversation

@genbit
Copy link
Copy Markdown
Contributor

@genbit genbit commented Oct 14, 2022

Add a link on top of the credentials docs to a proper aws guide

Signed-off-by: Sergey Generalov sergey@genbit.ru

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@genbit genbit requested a review from a team as a code owner October 14, 2022 20:25
@genbit genbit requested review from paragbhingre and removed request for a team October 14, 2022 20:25
@dannyrandall
Copy link
Copy Markdown
Contributor

could you add #4089 (comment) and #4089 (comment)? i forgot to add the label to stop them from merging in that PR 🥺

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #4091 (ab90953) into mainline (d603bb8) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           mainline    #4091   +/-   ##
=========================================
  Coverage     69.17%   69.17%           
=========================================
  Files           248      248           
  Lines         35609    35609           
  Branches        264      264           
=========================================
  Hits          24634    24634           
  Misses         9781     9781           
  Partials       1194     1194           
Impacted Files Coverage Δ
internal/pkg/aws/sessions/errors.go 33.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Add a link on top of the credentials docs to a proper aws guide

Signed-off-by: Sergey Generalov <sergey@genbit.ru>
Add "your" to indicate that error is on user side to fix

Signed-off-by: Sergey Generalov <sergey@genbit.ru>
@genbit
Copy link
Copy Markdown
Contributor Author

genbit commented Oct 17, 2022

@dannyrandall done

Comment thread site/content/docs/credentials.en.md Outdated
This section explains our recommendations around credentials to provide the best experience with the AWS Copilot CLI.
AWS Copilot uses AWS credentials to access AWS API, store and look up an [application's metadata](concepts/applications.en.md), and deploy and operate application's workloads.

You can learn more on how to configure AWS credentials at [Quick configuration with `aws configure`](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-quickstart.html#cli-configure-quickstart-config).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful for first-time users. I remember being confused by this when I first started! Thank you.

Comment thread site/content/docs/credentials.en.md Outdated
Comment thread site/content/docs/credentials.en.md Outdated
@huanjani huanjani added do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. and removed do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. labels Oct 31, 2022
@iamhopaul123 iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 28, 2022
@Lou1415926 Lou1415926 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 29, 2022
@Lou1415926 Lou1415926 added do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. and removed do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. labels Jan 17, 2023
Lou1415926 and others added 2 commits January 18, 2023 12:19
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Co-authored-by: Danny Randall <10566468+dannyrandall@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 18, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 48480 48436 +0.09
macOS (arm) 49140 49108 +0.07
linux (amd) 42652 42608 +0.10
linux (arm) 42052 41924 +0.31
windows (amd) 39408 39368 +0.10

@mergify mergify Bot merged commit f1ff69b into aws:mainline Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants