feat: app runner private services#4137
Merged
mergify[bot] merged 8 commits intomainlinefrom Oct 31, 2022
Merged
Conversation
* chore: arps manifest updates, cfn template * fix tests * address some feedback, staticcheck * add truncate function * fix integ tests
* chore: add vic metadata, add env sg to vpc connector * fix integ tests
* get private url * gen mocks, fix some tests * fix the last remaining tests * doc for exported func * address some feedback, fix bug from bug bash * address more feedback * add error for vpc ingress not found * remove go mod replace * change to sentinel error * clarify error response
* add new prompt for private services * some test cases * update new fields * address some feedback * add flag tests, list options for flag, add validation to ingress type * address feedback from @efekarakus * nit
* chore: don't create VPC Endpoint if endpoint specified * add env controller test
dannyrandall
requested review from
paragbhingre
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only unreviewed commits are:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.