Skip to content

chore: fix e2e and integration tests failed by 4166#4171

Merged
mergify[bot] merged 4 commits intoaws:mainlinefrom
Lou1415926:env/addon/misc/after/4166
Nov 11, 2022
Merged

chore: fix e2e and integration tests failed by 4166#4171
mergify[bot] merged 4 commits intoaws:mainlinefrom
Lou1415926:env/addon/misc/after/4166

Conversation

@Lou1415926
Copy link
Copy Markdown
Contributor

As well as removing deprecated references

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926 Lou1415926 requested a review from a team as a code owner November 11, 2022 19:07
@Lou1415926 Lou1415926 requested review from dannyrandall and removed request for a team November 11, 2022 19:07
@Lou1415926 Lou1415926 added the WIP Pull requests that are being modified now. label Nov 11, 2022
@github-actions
Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) v1.23.0 size (kiB) Delta (%)
macOS (amd) 47572 47548 +0.05
macOS (arm) 47572 48200 ❤️ -1.30
linux (amd) 41832 41812 +0.05
linux (arm) 41832 41220 🥺 +1.48
windows (amd) 38680 38664 +0.04

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4171 (d3007de) into mainline (ba5f300) will decrease coverage by 0.01%.
The diff coverage is 45.45%.

@@             Coverage Diff              @@
##           mainline    #4171      +/-   ##
============================================
- Coverage     69.28%   69.27%   -0.02%     
============================================
  Files           250      250              
  Lines         35881    35887       +6     
  Branches        264      264              
============================================
  Hits          24861    24861              
- Misses         9828     9834       +6     
  Partials       1192     1192              
Impacted Files Coverage Δ
internal/pkg/cli/init.go 22.25% <0.00%> (-0.35%) ⬇️
internal/pkg/addon/addons.go 86.56% <100.00%> (ø)
internal/pkg/docker/dockerengine/dockerengine.go 74.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lou1415926 Lou1415926 removed the WIP Pull requests that are being modified now. label Nov 11, 2022
@mergify mergify Bot merged commit 0fec236 into aws:mainline Nov 11, 2022
KollaAdithya pushed a commit to KollaAdithya/copilot-cli that referenced this pull request Nov 21, 2022
As well as removing deprecated references

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants