Skip to content

chore: add sc e2e test#4215

Merged
iamhopaul123 merged 9 commits intoaws:service-connectfrom
iamhopaul123:sc-e2e
Nov 28, 2022
Merged

chore: add sc e2e test#4215
iamhopaul123 merged 9 commits intoaws:service-connectfrom
iamhopaul123:sc-e2e

Conversation

@iamhopaul123
Copy link
Copy Markdown
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner November 23, 2022 20:12
@iamhopaul123 iamhopaul123 requested review from KollaAdithya and removed request for a team November 23, 2022 20:12
Comment thread e2e/multi-svc-app/back-end/main.go
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 23, 2022

🍕 Here are the new binary sizes!

Name New size (kiB) v1.23.0 size (kiB) Delta (%)
macOS (amd) 48068 47548 🥺 +1.09
macOS (arm) 48068 48200 ❤️ -0.27
linux (amd) 42248 41812 🥺 +1.04
linux (arm) 42248 41220 🥺 +2.49
windows (amd) 39052 38664 +1.00

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #4215 (1df2613) into service-connect (2b4b94b) will increase coverage by 0.04%.
The diff coverage is 87.50%.

@@                 Coverage Diff                 @@
##           service-connect    #4215      +/-   ##
===================================================
+ Coverage            69.10%   69.14%   +0.04%     
===================================================
  Files                  251      251              
  Lines                36037    36138     +101     
  Branches               264      264              
===================================================
+ Hits                 24902    24989      +87     
- Misses                9932     9940       +8     
- Partials              1203     1209       +6     
Impacted Files Coverage Δ
internal/pkg/aws/ecs/ecs.go 92.30% <ø> (ø)
internal/pkg/aws/ecs/errors.go 58.33% <ø> (ø)
internal/pkg/aws/ecs/task.go 85.29% <ø> (ø)
internal/pkg/cli/svc_deploy.go 31.18% <0.00%> (-0.16%) ⬇️
internal/pkg/exec/ssm_plugin.go 48.27% <ø> (ø)
internal/pkg/manifest/backend_svc.go 80.85% <ø> (-2.17%) ⬇️
internal/pkg/manifest/lb_web_svc.go 86.11% <ø> (-0.26%) ⬇️
internal/pkg/template/workload.go 55.90% <0.00%> (-0.71%) ⬇️
...rnal/pkg/deploy/cloudformation/stack/worker_svc.go 58.91% <40.00%> (-0.77%) ⬇️
...nal/pkg/deploy/cloudformation/stack/backend_svc.go 74.40% <50.00%> (-1.54%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

iamhopaul123 and others added 4 commits November 23, 2022 12:39
Release v1.24 docs


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Comment thread e2e/internal/client/outputs.go Outdated
Comment thread e2e/multi-svc-app/back-end/main.go Outdated
Copy link
Copy Markdown
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamhopaul123 iamhopaul123 merged commit 63aa02e into aws:service-connect Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants