fix: remove docker runtime version for test_commands

[0xO0O0]

Updates docker version from 18 --> 20

Fixes #4721

To address a requirement when running test_commands

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

[github-actions]

🍕 Here are the new binary sizes!

Name	New size (kiB)	size (kiB)	Delta (%)
macOS (amd)	50480	50324	+0.31
macOS (arm)	50300	50128	+0.34
linux (amd)	44436	44300	+0.31
linux (arm)	42756	42564	+0.45
windows (amd)	41320	41204	+0.28

[Lou1415926]

Hey @0xO0O0! Copilot loves external contributions Thank you very much ❤️!!

What do you think of @efekarakus's proposal here #4721 (comment)? If you think it sounds good, instead of bumping docker from 18 to 20, can we remove the line?

We will need to apply the same changes in five places:

1. The actual change:

   copilot-cli/internal/pkg/template/templates/cicd/pipeline_cfn.yml

   Line 304 in e1afe39

   docker: 18

2. bb, cc, and dd (the three files that you've changed in this PR) to pass the tests

3. copilot-cli/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/gh_template.yaml

   Line 244 in 8b4d37e

   docker: 18

   and

   copilot-cli/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/gh_template.yaml

   Line 244 in 8b4d37e

   docker: 18

   also for the testing purpose

Thank you again!!!

[0xO0O0]

@Lou1415926 very helpful, thank you! One thing, you posted the gh_template.yaml file twice, was there a third file that also needed updating ?

[Lou1415926]

ohh sorry one of the gh_template.yml was meant to be gvv1_template.yml!

copilot-cli/internal/pkg/deploy/cloudformation/stack/testdata/pipeline/ghv1_template.yml

Line 217 in 8b4d37e

docker: 18

[0xO0O0]

updated!

[0xO0O0]

If the docker version is no longer required, removing would be a good move. Let me know if that's the direction we want to move in and I'll update the pr.

[efekarakus]

@0xO0O0

If the docker version is no longer required, removing would be a good move. Let me know if that's the direction we want to move in and I'll update the pr.

That would be awesome, if you don't mind just deleting the install phase 🙏

[paragbhingre]

Thank you so much for your contribution ❤️

[efekarakus]

Thank you!!

[KollaAdithya]

Fix is now released in v1.28 https://github.com/aws/copilot-cli/releases/tag/v1.28.0. Thanks @0xO0O0 for reporting and contribution!