Skip to content

docs: add grace_period field to the NLB main listener #4802

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
paragbhingre:gracePeriodAndDeregistrationDocs
Apr 26, 2023
Merged

docs: add grace_period field to the NLB main listener #4802
mergify[bot] merged 2 commits intoaws:mainlinefrom
paragbhingre:gracePeriodAndDeregistrationDocs

Conversation

@paragbhingre
Copy link
Copy Markdown
Contributor

@paragbhingre paragbhingre commented Apr 25, 2023

#4734
This PR adds grace_period field to the NLB main listener and also removes this field from the additional listener rules for the ALB.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@paragbhingre paragbhingre requested a review from a team as a code owner April 25, 2023 22:26
@paragbhingre paragbhingre requested review from Lou1415926 and removed request for a team April 25, 2023 22:26
@paragbhingre paragbhingre marked this pull request as draft April 25, 2023 22:29
@paragbhingre paragbhingre changed the title docs: remove grace_period from the additional listener rules for http docs: add grace_period field to the NLB main listener Apr 25, 2023
@paragbhingre paragbhingre marked this pull request as ready for review April 25, 2023 22:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50556 50328 +0.45
macOS (arm) 50760 50516 +0.48
linux (amd) 44500 44304 +0.44
linux (arm) 42820 42564 +0.60
windows (amd) 41376 41204 +0.42

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #4802 (127e994) into mainline (71aa843) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           mainline    #4802   +/-   ##
=========================================
  Coverage     69.99%   69.99%           
=========================================
  Files           286      286           
  Lines         40923    40923           
  Branches        280      280           
=========================================
  Hits          28644    28644           
  Misses        10899    10899           
  Partials       1380     1380           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mergify mergify Bot merged commit 1849d46 into aws:mainline Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants