chore: boilerplate for `local run` command by Varun359 · Pull Request #5049 · aws/copilot-cli

Varun359 · 2023-07-06T22:22:36Z

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

github-actions · 2023-07-06T22:32:57Z

🍕 Here are the new binary sizes!

Name	New size (kiB)	size (kiB)	Delta (%)
macOS (amd)	51404	50748	🥺 +1.29
macOS (arm)	51604	50956	🥺 +1.27
linux (amd)	45252	44680	🥺 +1.28
linux (arm)	43524	43012	🥺 +1.19
windows (amd)	42076	41548	🥺 +1.27

codecov-commenter · 2023-07-06T22:41:35Z

Codecov Report

❌ Patch coverage is 17.39130% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.67%. Comparing base (55dba4d) to head (596c8da).
⚠️ Report is 387 commits behind head on mainline.

Files with missing lines	Patch %	Lines
internal/pkg/cli/local_run.go	17.39%	38 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           mainline    #5049      +/-   ##
============================================
- Coverage     69.73%   69.67%   -0.07%     
============================================
  Files           293      294       +1     
  Lines         43003    43049      +46     
  Branches        285      285              
============================================
+ Hits          29988    29994       +6     
- Misses        11552    11593      +41     
+ Partials       1463     1462       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lou1415926

LGTM all are nits

iamhopaul123

Varun359 added 6 commits June 28, 2023 21:30

readme updated

29b76b5

readme updated

042c746

original readme

ed95e3f

local run template

ba81f0d

Todo added in execute

a7b8002

corrected code format

ab75d8f

Varun359 requested a review from a team as a code owner July 6, 2023 22:22

Varun359 requested review from dannyrandall and removed request for a team July 6, 2023 22:22

license added

cb242d9

Varun359 force-pushed the local-run-template branch from f8cf094 to cb242d9 Compare July 6, 2023 22:26

iamhopaul123 reviewed Jul 7, 2023

View reviewed changes

added flags validation

ca8e131

Varun359 force-pushed the local-run-template branch from a4ac5fd to ca8e131 Compare July 7, 2023 18:37

iamhopaul123 reviewed Jul 7, 2023

View reviewed changes

Comment thread internal/pkg/cli/local_run.go Outdated

Comment thread internal/pkg/cli/local_run.go Outdated

added validating workloads locally

08355b4

Varun359 force-pushed the local-run-template branch from dd93b54 to 08355b4 Compare July 7, 2023 19:50

changed test case

083cd17

Varun359 force-pushed the local-run-template branch from 4ba8648 to 083cd17 Compare July 7, 2023 20:41

dannyrandall reviewed Jul 7, 2023

View reviewed changes

Comment thread internal/pkg/cli/local_run.go

Comment thread internal/pkg/cli/local_run.go Outdated

Comment thread internal/pkg/cli/local_run.go Outdated

Comment thread internal/pkg/cli/local_run.go Outdated

changes made retrieving the envs and wklds

09d57dd

Varun359 force-pushed the local-run-template branch from b80ad8a to 09d57dd Compare July 11, 2023 17:44

nit in comment

fc7b875

Varun359 force-pushed the local-run-template branch from 8c70fc4 to fc7b875 Compare July 11, 2023 18:04

Merge branch 'aws:mainline' into local-run-template

2650035

Varun359 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 11, 2023

envTemplateBootstrap variable modified

7fdfb38

Varun359 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 11, 2023

dannyrandall reviewed Jul 12, 2023

View reviewed changes

few corrections made

82ec103

Lou1415926 reviewed Jul 12, 2023

View reviewed changes

Comment thread internal/pkg/cli/local_run.go Outdated

Comment thread internal/pkg/cli/local_run.go Outdated

Comment thread internal/pkg/cli/local_run.go Outdated

few corrections made

134f4f1

Varun359 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 12, 2023

Varun359 and others added 3 commits July 12, 2023 23:40

Merge branch 'aws:mainline' into local-run-template

a124d67

prompt order changed to workload first

f635366

static check changes made

1b29ce2

Varun359 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 13, 2023

Varun359 requested a review from a team July 13, 2023 16:58

Varun359 and others added 2 commits July 13, 2023 11:35

Merge branch 'aws:mainline' into local-run-template

3d0cf9a

changed test file

cf6be25

Varun359 mentioned this pull request Jul 14, 2023

chore: decrypt secrets from SSM and Secrets Manager #5086

Closed

Lou1415926 approved these changes Jul 14, 2023

View reviewed changes

Lou1415926 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 14, 2023

nits error messages

5426838

Varun359 force-pushed the local-run-template branch from 3a72412 to 5426838 Compare July 17, 2023 15:14

Varun359 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 17, 2023

iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 18, 2023

iamhopaul123 reviewed Jul 18, 2023

View reviewed changes

Comment thread internal/pkg/cli/local_run.go

Comment thread internal/pkg/cli/local_run.go Outdated

Comment thread internal/pkg/cli/local_run.go Outdated

remove ask

b6f10b9

Varun359 force-pushed the local-run-template branch from da0b904 to b6f10b9 Compare July 18, 2023 22:18

comments added to public functions

c9c6f4c

Varun359 force-pushed the local-run-template branch from 866ac99 to c9c6f4c Compare July 18, 2023 22:28

Merge branch 'aws:mainline' into local-run-template

e470916

iamhopaul123 approved these changes Jul 18, 2023

View reviewed changes

Comment thread internal/pkg/cli/local_run.go Outdated

commit changed

596c8da

iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 19, 2023

mergify Bot merged commit 482e314 into aws:mainline Jul 19, 2023

Conversation

Varun359 commented Jul 6, 2023

Uh oh!

github-actions Bot commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lou1415926 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iamhopaul123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Jul 6, 2023 •

edited

Loading

codecov-commenter commented Jul 6, 2023 •

edited

Loading