chore: add --env-var-override and --port-override flags to local run#5201
Merged
mergify[bot] merged 23 commits intoaws:mainlinefrom Aug 22, 2023
Merged
chore: add --env-var-override and --port-override flags to local run#5201mergify[bot] merged 23 commits intoaws:mainlinefrom
--env-var-override and --port-override flags to local run#5201mergify[bot] merged 23 commits intoaws:mainlinefrom
Conversation
dannyrandall
requested review from
CaptainCarpensir
and removed request for
a team
|
🍕 Here are the new binary sizes!
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #5201 +/- ##
============================================
+ Coverage 69.50% 69.71% +0.21%
============================================
Files 295 296 +1
Lines 43941 44018 +77
Branches 286 286
============================================
+ Hits 30539 30686 +147
+ Misses 11909 11842 -67
+ Partials 1493 1490 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iamhopaul123
approved these changes
Aug 22, 2023
Lou1415926
approved these changes
Aug 22, 2023
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
LGTM just a question!
Comment on lines
+452
to
+456
| func (p *portOverrides) Type() string { | ||
| return "list" | ||
| } | ||
|
|
||
| func (p *portOverrides) String() string { |
Contributor
There was a problem hiding this comment.
dumb question: where are they used 👀 !
Contributor
Author
There was a problem hiding this comment.
honestly a great question - i tried to figure it out but don't understand why String() is called. They are required to implement the interface: https://pkg.go.dev/github.com/spf13/pflag#Value.
Type() is called when you do --help and is printed next to the flag name
String() is called when parsing the flags, but it's never printed anywhere ¯\(ツ)/¯ maybe there's some debugging output or something but i haven't seen it
Lou1415926
added
the
do-not-merge
dannyrandall
removed
the
do-not-merge
mergify Bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
Builds on top of #5201, the diff will get much smaller once that PR is merged. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.