fix: never prompt for env deployment #5262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
just confirming that this is only in the case of the user including the |
|
🍕 Here are the new binary sizes!
|
Contributor
Author
|
Are there any circumstances under which we would actually want to prompt for env deployment? When they initialize the env, it's implied that they have to deploy it for the command to complete. Maybe we prompt for env deployment when they have not specified the environment flag? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mainline #5262 +/- ##
=========================================
Coverage 69.78% 69.78%
=========================================
Files 296 296
Lines 44545 44539 -6
Branches 286 286
=========================================
- Hits 31086 31082 -4
+ Misses 11954 11951 -3
- Partials 1505 1506 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dannyrandall
approved these changes
Aug 31, 2023
huanjani
approved these changes
Aug 31, 2023
Contributor
Author
bvtujo
changed the title
KollaAdithya
pushed a commit
to KollaAdithya/copilot-cli
that referenced
this pull request
Oct 18, 2023
…5262) The new logic with no flags is: 1. Check whether workload is uninitialized. If so, prompt for workload init. 2. Check whether environment is uninitialized. If so, prompt for env init, then proceed directly to env deploy. 3. Deploy workload. Now, there is no extra prompt for environment deployment at any time. The behavior is purely opt-in, which actually I think makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic with no flags is:
Now, there is no extra prompt for environment deployment at any time. The behavior is purely opt-in, which actually I think makes more sense.