chore: make app delete default to no in confirmation prompt#5267
Merged
mergify[bot] merged 1 commit intoaws:mainlinefrom Aug 31, 2023
Merged
chore: make app delete default to no in confirmation prompt#5267mergify[bot] merged 1 commit intoaws:mainlinefrom
mergify[bot] merged 1 commit intoaws:mainlinefrom
Conversation
|
🍕 Here are the new binary sizes!
|
huanjani
approved these changes
Aug 31, 2023
iamhopaul123
approved these changes
Aug 31, 2023
KollaAdithya
pushed a commit
to KollaAdithya/copilot-cli
that referenced
this pull request
Oct 18, 2023
Quick fix to address aws#5258. We shouldn't default to "yes" on app delete confirmation, as that makes it easy to destroy apps with an errant keypress. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to address #5258. We shouldn't default to "yes" on app delete confirmation, as that makes it easy to destroy apps with an errant keypress.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.