Skip to content

chore: various run local fixes#5459

Merged
mergify[bot] merged 7 commits intoaws:mainlinefrom
dannyrandall:chore/run-local-fixes
Nov 9, 2023
Merged

chore: various run local fixes#5459
mergify[bot] merged 7 commits intoaws:mainlinefrom
dannyrandall:chore/run-local-fixes

Conversation

@dannyrandall
Copy link
Copy Markdown
Contributor

@dannyrandall dannyrandall commented Nov 8, 2023

Fixes the following issues:

  • Download the ARM version of session manager plugin in pause container if using ARM binary
  • Considers all containers "essential" as we did previously - meaning, if a container stops, that is reported as an error
  • Adds back status messages of what the orchestrator is doing after Stop()
  • Passes --init to docker run for the pause container so it responds to docker stop (https://www.fpcomplete.com/blog/docker-demons-pid1-orphans-zombies-signals/)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@dannyrandall dannyrandall requested a review from a team as a code owner November 8, 2023 23:39
@dannyrandall dannyrandall requested review from efekarakus and removed request for a team November 8, 2023 23:39
Comment thread internal/pkg/docker/orchestrator/orchestrator.go
@Lou1415926 Lou1415926 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 9, 2023
@dannyrandall dannyrandall removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 9, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 9, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 55204 51976 😭 +6.21
macOS (arm) 56168 52812 😭 +6.35
linux (amd) 48448 45716 😭 +5.98
linux (arm) 47748 45060 😭 +5.97
windows (amd) 45680 43168 😭 +5.82

@mergify mergify Bot merged commit 9d9e8d6 into aws:mainline Nov 9, 2023
@dannyrandall dannyrandall deleted the chore/run-local-fixes branch November 9, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants