Skip to content

Conversation

@KollaAdithya
Copy link
Contributor

@KollaAdithya KollaAdithya commented Dec 8, 2023

I did not anticipate that it breaks the permissions required to create environment and services.

Previously we added the logic to pass all the HostedZoneId as params in the custom resource in #5315.

But this introduces a bug as @Lou1415926 described in this issue #5535 (comment)

So reverting this changes as these are not necessary because listHostedZonesByName always fetches all the public hosted zones followed by private hosted zones.


And also I think these modifications for filtering of hosted zones are not required in custom resources
because listHostedZonesByName api call always lists all the public hosted zones first and at last it lists private hosted zones.
The logic we have in all the custom resources always works to fetch public hosted zone.

const data = await appRoute53Client.listHostedZonesByName({
        DNSName: domainName,
        MaxItems: "1",
    }).promise();



@KollaAdithya KollaAdithya requested a review from a team as a code owner December 8, 2023 18:33
@KollaAdithya KollaAdithya requested review from CaptainCarpensir and removed request for a team December 8, 2023 18:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.04%. Comparing base (ae710d5) to head (37accd3).
⚠️ Report is 159 commits behind head on mainline.

Files with missing lines Patch % Lines
internal/pkg/cli/deploy/rdws.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #5540   +/-   ##
=========================================
  Coverage     70.04%   70.04%           
=========================================
  Files           302      302           
  Lines         46351    46286   -65     
  Branches        309      301    -8     
=========================================
- Hits          32465    32422   -43     
+ Misses        12307    12291   -16     
+ Partials       1579     1573    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56792 58072 ❤️ -2.20
macOS (arm) 57800 59136 ❤️ -2.26
linux (amd) 49796 50924 ❤️ -2.22
linux (arm) 49088 50180 ❤️ -2.18
windows (amd) 46936 47964 ❤️ -2.14

@mergify mergify bot merged commit 8de7d2b into aws:mainline Dec 11, 2023
@KollaAdithya KollaAdithya deleted the revert/fix/hostedzone branch December 20, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants