fix: revert changes to custom resources of passing hostedzoneids #5540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not anticipate that it breaks the permissions required to create environment and services.
Previously we added the logic to pass all the HostedZoneId as params in the custom resource in #5315.
But this introduces a bug as @Lou1415926 described in this issue #5535 (comment)
So reverting this changes as these are not necessary because
listHostedZonesByNamealways fetches all the public hosted zones followed by private hosted zones.And also I think these modifications for filtering of hosted zones are not required in custom resources because
listHostedZonesByNameapi call always lists all the public hosted zones first and at last it lists private hosted zones. The logic we have in all the custom resources always works to fetch public hosted zone.