chore: allow decrypt of secrets with CMK #5576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KollaAdithya
requested review from
iamhopaul123
and removed request for
a team
|
🍕 Here are the new binary sizes!
|
Lou1415926
approved these changes
Dec 21, 2023
| - 'kms:Decrypt' | ||
| Resource: | ||
| - !Ref ArtifactKeyARN | ||
| - Effect: 'Allow' |
There was a problem hiding this comment.
nitnitnitnitnit™️ !
Suggested change
| - Effect: 'Allow' | |
| Sid: DecryptAppRegionalArtifactKey | |
| - Sid: DecryptTaggedKMSKey | |
| Effect: 'Allow' |
| - 'kms:Decrypt' | ||
| Resource: | ||
| - !Ref ArtifactKeyARN | ||
| - Effect: 'Allow' |
There was a problem hiding this comment.
samesies™️
Suggested change
| - Effect: 'Allow' | |
| Sid: DecryptAppRegionalArtifactKey | |
| - Sid: DecryptTaggedKMSKey | |
| Effect: 'Allow' |
(idk if the indentation is correct, so don't "commit suggestion" just in case 😂 )
Lou1415926
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #5576 +/- ##
=========================================
Coverage 70.04% 70.04%
=========================================
Files 302 302
Lines 46493 46498 +5
Branches 301 301
=========================================
+ Hits 32565 32570 +5
Misses 12345 12345
Partials 1583 1583 ☔ View full report in Codecov by Sentry. |
iamhopaul123
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #5570
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.