Migrate XGBoost integ tests to dlc v2#5852
Merged
Jyothirmaikottu merged 32 commits intomainfrom Mar 31, 2026
Merged
Conversation
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 118 X-AI-Prompt: rebase this branch to main and prepare cr
--- X-AI-Tool: Human X-AI-Prompt: prepare-cr
feat: Add XGBoost benchmark tests and release workflow Migrate XGBoost benchmark tests from Hydra (SMFrameworksXGBoost3_0-5Tests) to pytest + SageMaker SDK, and add a GitHub Actions release workflow for the XGBoost SageMaker container. Benchmark tests cover all 7 categories from the Hydra suite (40 total test cases): training objective, tree method, max depth, num round, data size, instance type, and content type/input mode. Tests run SageMaker training jobs in the CI account using XGBoostSageMakerRole, with benchmark data accessed cross-account from the amazonai-algorithms-benchmarking bucket in 900597767885 via bucket policy. The release workflow (release-sagemaker-xgboost.yml) includes build, unit test, security test, and benchmark test jobs. Release and generate-release-spec jobs are stubbed as TODOs pending release readiness. Also creates stub directories for integration and container tests under test/xgboost/ for future migration. ai-dev-branch commit IDs: - e24272d - da1ae1e The prompts used are captured in the footers of those commits. The initial prompt was: rebase this branch to main and prepare cr --- X-AI-Handle-Time-Seconds: 118 X-AI-Line-Changes: New:567, Altered:0, Deleted:0 X-Human-Line-Changes: New:0, Altered:1, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:567, Altered:0, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 118 X-AI-Change-Count: 1 X-Human-Change-Count: 1 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: true
--- X-AI-Tool: Human X-AI-Prompt: pushed the changes and can you fix them
style: Fix pre-commit formatting for XGBoost benchmark tests Apply black/ruff formatting fixes flagged by pre-commit hooks: expand compressed dicts and function call args to one-per-line, remove extra blank lines before imports, and wrap long log lines. ai-dev-branch commit IDs: - 77d13b7 The prompts used are captured in the footers of those commits. The initial prompt was: pushed the changes and can you fix them --- X-AI-Handle-Time-Seconds: 0 X-AI-Line-Changes: New:0, Altered:0, Deleted:0 X-Human-Line-Changes: New:188, Altered:62, Deleted:0 X-AI-Change-Count: 0 X-Human-Change-Count: 1 X-CR-Amendment: false
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 28 X-AI-Prompt: i need to modify the wf to test it to run
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 20 X-AI-Prompt: use SagemakerRole for now instead of XGboostSagemakerRole
fix: Add push trigger for testing and use SageMakerRole Add temporary push trigger on xgboost-release branch to test the workflow. Switch from XGBoostSageMakerRole to SageMakerRole for benchmark tests. ai-dev-branch commit IDs: - 0851de5 - ec02156 The prompts used are captured in the footers of those commits. The initial prompt was: i need to modify the wf to test it to run --- X-AI-Handle-Time-Seconds: 48 X-AI-Line-Changes: New:2, Altered:3, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:2, Altered:3, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 48 X-AI-Change-Count: 2 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 2 X-CR-Amendment: false
--- X-AI-Tool: Human X-AI-Prompt: <none - new session>
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 28
X-AI-Prompt: File "/tmp/codebuild-66e41599-9565-4813-9d1e-6e8c713b8ad9/output/src1593/src/2f80db70_a77f_4b71_a412_f48319e5a33e/actions-runner/_work/deep-learning-containers/deep-learning-containers/.venv/lib64/python3.12/site-packages/_pytest/config/argparsing.py", line 429, in addoption
raise ValueError(f"option names {conflict} already added")
ValueError: option names {'--image-uri'} already added
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 93 X-AI-Prompt: check for red flags in the entire test logic
fix: Remove duplicate pytest options and add training job cleanup Fix duplicate --image-uri option crash by removing redundant pytest_addoption from xgboost conftest (inherited from parent). Add try/finally cleanup to stop SageMaker training jobs on failure. Use SageMakerRole instead of XGBoostSageMakerRole. ai-dev-branch commit IDs: - 3dc5695 - 7e3e008 - 4cf6d94 The prompts used are captured in the footers of those commits. The initial prompt was: ValueError: option names {'--image-uri'} already added --- X-AI-Handle-Time-Seconds: 121 X-AI-Line-Changes: New:7, Altered:3, Deleted:25 X-Human-Line-Changes: New:0, Altered:1, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:7, Altered:3, Deleted:25 X-AI-Handle-Time-Seconds-Kiro-cli: 121 X-AI-Change-Count: 2 X-Human-Change-Count: 1 X-AI-Change-Count-Kiro-cli: 2 X-CR-Amendment: false
--- X-AI-Tool: Human X-AI-Prompt: <none - new session>
chore: Rename workflow to Release - XGBoost SageMaker ai-dev-branch commit IDs: - fe321a4 The prompts used are captured in the footers of those commits. The initial prompt was: prepare cr --- X-AI-Handle-Time-Seconds: 0 X-AI-Line-Changes: New:0, Altered:0, Deleted:0 X-Human-Line-Changes: New:0, Altered:1, Deleted:0 X-AI-Change-Count: 0 X-Human-Change-Count: 1 X-CR-Amendment: false
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 33 X-AI-Prompt: xgboost/benchmarks/test_training_content_type.py::test_content_type[recordio-protobuf-pipe] 2026-03-30 20:56:42 Starting - Starting the training job... 2026-03-30 20:56:56 Starting - Preparing the instances for training... 2026-03-30 20:57:32 Downloading - Downloading the training image... 2026-03-30 20:58:08 Training - Training image download completed. Training in progress.../miniconda3/lib/python3.10/site-packages/sagemaker_containers/_server.py:22: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81. import pkg_resources [2026-03-30:20:58:30:INFO] Imported framework sagemaker_xgboost_container.training [2026-03-30:20:58:30:INFO] Failed to parse hyperparameter objective value reg:squarederror to Json. Returning the value itself [2026-03-30:20:58:30:INFO] Failed to parse hyperparameter tree_method value exact to Json. Returning the value itself [2026-03-30:20:58:30:INFO] No GPUs detected (normal if no gpus installed) [2026-03-30:20:58:30:INFO] Running XGBoost Sagemaker in algorithm mode [2026-03-30:20:58:30:INFO] Determined 0 GPU(s) available on the instance. [2026-03-30:20:58:30:INFO] Pipe path /opt/ml/input/data/train found. [2026-03-30:20:58:30:INFO] Path /opt/ml/input/data/validation does not exist! [2026-03-30:20:58:30:INFO] files path: ['/opt/ml/input/data/train'] [2026-03-30:20:58:30:ERROR] Reporting training FAILURE [2026-03-30:20:58:30:ERROR] framework error: Traceback (most recent call last): File "/miniconda3/lib/python3.10/site-packages/sagemaker_containers/_trainer.py", line 84, in train entrypoint() File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/training.py", line 102, in main train(framework.training_env()) File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/training.py", line 98, in train run_algorithm_mode() File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/training.py", line 64, in run_algorithm_mode sagemaker_train( File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/algorithm_mode/train.py", line 280, in sagemaker_train raise exc.UserError(f"No data in training channel path {train_path}") sagemaker_algorithm_toolkit.exceptions.UserError: No data in training channel path /opt/ml/input/data/train
fix: Remove unsupported Pipe mode benchmark tests Remove recordio-protobuf and parquet Pipe mode tests as XGBoost algorithm mode does not support pipe input for these formats. ai-dev-branch commit IDs: - 187f127 The prompts used are captured in the footers of those commits. The initial prompt was: sagemaker_algorithm_toolkit.exceptions.UserError: No data in training channel path /opt/ml/input/data/train --- X-AI-Handle-Time-Seconds: 33 X-AI-Line-Changes: New:0, Altered:2, Deleted:2 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:2, Deleted:2 X-AI-Handle-Time-Seconds-Kiro-cli: 33 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: true
--- X-AI-Tool: Human X-AI-Prompt: looks like it is rebuilding some parts of docker file is there a way to avoid it
--- X-AI-Tool: Human X-AI-Prompt: how to create a new policy
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 18 X-AI-Prompt: remoce XGBOOST_SAGEMAKER_ROLE
chore: Remove unused XGBOOST_SAGEMAKER_ROLE constant ai-dev-branch commit IDs: - 013eaa4 - fb55891 - 7096f0c The prompts used are captured in the footers of those commits. The initial prompt was: remoce XGBOOST_SAGEMAKER_ROLE --- X-AI-Handle-Time-Seconds: 18 X-AI-Line-Changes: New:0, Altered:0, Deleted:1 X-Human-Line-Changes: New:9, Altered:4, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:0, Deleted:1 X-AI-Handle-Time-Seconds-Kiro-cli: 18 X-AI-Change-Count: 1 X-Human-Change-Count: 2 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 34 X-AI-Prompt: modify the wf to run each job parallely under benchmark tests
feat: Parallelize benchmark tests using strategy matrix Split benchmark-test into 7 parallel jobs using strategy.matrix, one per test module. Uses fail-fast: false so failures don't cancel other modules. ai-dev-branch commit IDs: - 2631d13 The prompts used are captured in the footers of those commits. The initial prompt was: modify the wf to run each job parallely under benchmark tests --- X-AI-Handle-Time-Seconds: 34 X-AI-Line-Changes: New:11, Altered:4, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:11, Altered:4, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 34 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
--- X-AI-Tool: Human X-AI-Prompt: <none - new session>
chore: Increase benchmark test timeout to 90 minutes ai-dev-branch commit IDs: - 0dd9434 The prompts used are captured in the footers of those commits. The initial prompt was: prepare cr --- X-AI-Handle-Time-Seconds: 0 X-AI-Line-Changes: New:0, Altered:0, Deleted:0 X-Human-Line-Changes: New:0, Altered:1, Deleted:0 X-AI-Change-Count: 0 X-Human-Change-Count: 1 X-CR-Amendment: false
--- X-AI-Tool: Human X-AI-Prompt: <none - new session>
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 32 X-AI-Prompt: diff --git a/test/xgboost/benchmarks/conftest.py b/test/xgboost/benchmarks/conftest.py index 7cab415..dd4384f 100644 --- a/test/xgboost/benchmarks/conftest.py +++ b/test/xgboost/benchmarks/conftest.py @@ -81,9 +81,7 @@ def run_training_job( ), } - LOGGER.info( - f"Starting benchmark job: {job_name} ({instance_count}x {instance_type})" - ) + LOGGER.info(f"Starting benchmark job: {job_name} ({instance_count}x {instance_type})") sm = boto3.client("sagemaker") start = time.time() try: diff --git a/test/xgboost/benchmarks/test_training_content_type.py b/test/xgboost/benchmarks/test_training_content_type.py index 71808a8..e070bd0 100644 --- a/test/xgboost/benchmarks/test_training_content_type.py +++ b/test/xgboost/benchmarks/test_training_content_type.py @@ -41,9 +41,7 @@ BASE_HP = { "parquet-file", ], ) -def test_content_type( - image_uri, role, benchmark_bucket, dataset_path, content_type, input_mode -): +def test_content_type(image_uri, role, benchmark_bucket, dataset_path, content_type, input_mode): _, duration, desc = run_training_job( image_uri=image_uri, role=role,
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 27 X-AI-Prompt: test training content type and trianing num round take more than 90 mins.
fix: Pre-commit formatting and increase benchmark timeout to 150min Apply pre-commit formatting fixes and increase benchmark job timeout from 90 to 150 minutes for content_type and num_round modules which use large datasets. ai-dev-branch commit IDs: - d73bcc0 - 8a6a668 - dc2e0f0 The prompts used are captured in the footers of those commits. The initial prompt was: pre-commit formatting fixes --- X-AI-Handle-Time-Seconds: 59 X-AI-Line-Changes: New:0, Altered:2, Deleted:2 X-Human-Line-Changes: New:0, Altered:1, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:0, Altered:2, Deleted:2 X-AI-Handle-Time-Seconds-Kiro-cli: 59 X-AI-Change-Count: 2 X-Human-Change-Count: 1 X-AI-Change-Count-Kiro-cli: 2 X-CR-Amendment: false
5e5fa6c to
b01aac9
Compare
b01aac9 to
bb2e621
Compare
bhanutejagk
reviewed
Mar 31, 2026
bhanutejagk
approved these changes
Mar 31, 2026
bhanutejagk
pushed a commit
that referenced
this pull request
Mar 31, 2026
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 118
X-AI-Prompt: rebase this branch to main and prepare cr
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: prepare-cr
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: pushed the changes and can you fix them
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 28
X-AI-Prompt: i need to modify the wf to test it to run
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 20
X-AI-Prompt: use SagemakerRole for now instead of XGboostSagemakerRole
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: <none - new session>
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 28
X-AI-Prompt: File "/tmp/codebuild-66e41599-9565-4813-9d1e-6e8c713b8ad9/output/src1593/src/2f80db70_a77f_4b71_a412_f48319e5a33e/actions-runner/_work/deep-learning-containers/deep-learning-containers/.venv/lib64/python3.12/site-packages/_pytest/config/argparsing.py", line 429, in addoption
raise ValueError(f"option names {conflict} already added")
ValueError: option names {'--image-uri'} already added
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 93
X-AI-Prompt: check for red flags in the entire test logic
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: <none - new session>
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 33
X-AI-Prompt: xgboost/benchmarks/test_training_content_type.py::test_content_type[recordio-protobuf-pipe] 2026-03-30 20:56:42 Starting - Starting the training job...
2026-03-30 20:56:56 Starting - Preparing the instances for training...
2026-03-30 20:57:32 Downloading - Downloading the training image...
2026-03-30 20:58:08 Training - Training image download completed. Training in progress.../miniconda3/lib/python3.10/site-packages/sagemaker_containers/_server.py:22: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
import pkg_resources
[2026-03-30:20:58:30:INFO] Imported framework sagemaker_xgboost_container.training
[2026-03-30:20:58:30:INFO] Failed to parse hyperparameter objective value reg:squarederror to Json.
Returning the value itself
[2026-03-30:20:58:30:INFO] Failed to parse hyperparameter tree_method value exact to Json.
Returning the value itself
[2026-03-30:20:58:30:INFO] No GPUs detected (normal if no gpus installed)
[2026-03-30:20:58:30:INFO] Running XGBoost Sagemaker in algorithm mode
[2026-03-30:20:58:30:INFO] Determined 0 GPU(s) available on the instance.
[2026-03-30:20:58:30:INFO] Pipe path /opt/ml/input/data/train found.
[2026-03-30:20:58:30:INFO] Path /opt/ml/input/data/validation does not exist!
[2026-03-30:20:58:30:INFO] files path: ['/opt/ml/input/data/train']
[2026-03-30:20:58:30:ERROR] Reporting training FAILURE
[2026-03-30:20:58:30:ERROR] framework error:
Traceback (most recent call last):
File "/miniconda3/lib/python3.10/site-packages/sagemaker_containers/_trainer.py", line 84, in train
entrypoint()
File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/training.py", line 102, in main
train(framework.training_env())
File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/training.py", line 98, in train
run_algorithm_mode()
File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/training.py", line 64, in run_algorithm_mode
sagemaker_train(
File "/miniconda3/lib/python3.10/site-packages/sagemaker_xgboost_container/algorithm_mode/train.py", line 280, in sagemaker_train
raise exc.UserError(f"No data in training channel path {train_path}")
sagemaker_algorithm_toolkit.exceptions.UserError: No data in training channel path /opt/ml/input/data/train
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: looks like it is rebuilding some parts of docker file is there a way to avoid it
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: how to create a new policy
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 18
X-AI-Prompt: remoce XGBOOST_SAGEMAKER_ROLE
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 34
X-AI-Prompt: modify the wf to run each job parallely under benchmark tests
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: <none - new session>
* Human changes made during kiro-cli session after prompt completion.
---
X-AI-Tool: Human
X-AI-Prompt: <none - new session>
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 32
X-AI-Prompt: diff --git a/test/xgboost/benchmarks/conftest.py b/test/xgboost/benchmarks/conftest.py
index 7cab415..dd4384f 100644
--- a/test/xgboost/benchmarks/conftest.py
+++ b/test/xgboost/benchmarks/conftest.py
@@ -81,9 +81,7 @@ def run_training_job(
),
}
- LOGGER.info(
- f"Starting benchmark job: {job_name} ({instance_count}x {instance_type})"
- )
+ LOGGER.info(f"Starting benchmark job: {job_name} ({instance_count}x {instance_type})")
sm = boto3.client("sagemaker")
start = time.time()
try:
diff --git a/test/xgboost/benchmarks/test_training_content_type.py b/test/xgboost/benchmarks/test_training_content_type.py
index 71808a8..e070bd0 100644
--- a/test/xgboost/benchmarks/test_training_content_type.py
+++ b/test/xgboost/benchmarks/test_training_content_type.py
@@ -41,9 +41,7 @@ BASE_HP = {
"parquet-file",
],
)
-def test_content_type(
- image_uri, role, benchmark_bucket, dataset_path, content_type, input_mode
-):
+def test_content_type(image_uri, role, benchmark_bucket, dataset_path, content_type, input_mode):
_, duration, desc = run_training_job(
image_uri=image_uri,
role=role,
* AI changes made during Kiro-cli session
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 27
X-AI-Prompt: test training content type and trianing num round take more than 90 mins.
* remove trigger
* fix format
bhanutejagk
pushed a commit
that referenced
this pull request
Mar 31, 2026
--- X-AI-Tool: Human X-AI-Prompt: i have the workflow setup for xgboost in https://github.com/aws/deep-learning-containers ready until release through pr - #5852 and i want to add the genereate release spec and release image steps like vllm - https://github.com/aws/deep-learning-containers/actions/runs/23257998179/job/67626225687. ALso check for local DLContainersReleaseLogicV2 repo to understand what have been added to the release logic to add xgboost config and comment out the benchmark tests https://github.com/aws/deep-learning-containers/blob/main/.github/workflows/release-sagemaker-xgboost.yml since they already passed in the pr and now i wanna test the gamma release
bhanutejagk
pushed a commit
that referenced
this pull request
Mar 31, 2026
feat: Add generate-release-spec and release-image steps to XGBoost release workflow Wire the release pipeline for XGBoost SageMaker gamma testing by adding generate-release-spec and release-image jobs modeled after the vLLM SageMaker auto-release workflow. The generate-release-spec job gates on unit-test and security-test, checks if release is enabled in config, then generates the release spec. The release-image job calls the reusable-release-image workflow with the environment from config (gamma). Benchmark tests are commented out since they already passed in PR #5852. Also set public_registry to false since xgboost uses private ECR only. ai-dev-branch commit IDs: bf9bfc1 The prompts used are captured in the footers of those commits. The initial prompt was: do it --- X-AI-Handle-Time-Seconds: 28 X-AI-Line-Changes: New:38, Altered:38, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:38, Altered:38, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 28 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: true
bhanutejagk
pushed a commit
that referenced
this pull request
Apr 1, 2026
feat: Add release pipeline for XGBoost SageMaker gamma testing Add generate-release-spec and release-image jobs to the XGBoost SageMaker release workflow, modeled after the vLLM auto-release workflow. The generate-release-spec job gates on unit-test and security-test, checks if release is enabled in config, then generates the release spec. The release-image job calls the reusable-release-image workflow with the environment from config. Benchmark tests are commented out since they already passed in PR #5852. Also set public_registry to false since xgboost uses private ECR only. ai-dev-branch commit IDs: bd34e9a The prompts used are captured in the footers of those commits. The initial prompt was: no this has made a mess now the pr contains only that changes of 2 lines --- X-AI-Handle-Time-Seconds: 53 X-AI-Line-Changes: New:41, Altered:38, Deleted:0 X-Human-Line-Changes: New:0, Altered:0, Deleted:0 X-AI-Line-Changes-Kiro-cli: New:41, Altered:38, Deleted:0 X-AI-Handle-Time-Seconds-Kiro-cli: 53 X-AI-Change-Count: 1 X-Human-Change-Count: 0 X-AI-Change-Count-Kiro-cli: 1 X-CR-Amendment: false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
05afc2e
Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).