Xgboost migration fixes#5892
Merged
Merged
Conversation
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 152 X-AI-Prompt: the tags of xgboost are 3.0-5, 3.0-5-1.0.15.0, 3.0-5-cpu-py3, we need to maintain this in the repo config
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 79 X-AI-Prompt: remove these changes its not need, we need to modify the ci tag to not have sagemaker init
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 19 X-AI-Prompt: remove cuda, os version
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 51 X-AI-Prompt: chekc the workflows and make modifications
fix: simplify XGBoost CI tags and fix integ test workflow ordering
Simplify the CI image tags for XGBoost PR and release workflows by
removing the cuda version, OS version, and sagemaker suffix. The
tags now follow the pattern xgboost-{version}-{device}-{python}-{id}
which aligns with the public release tag scheme.
Fix the integration test workflow so that E2E tests depend on
container tests completing first, matching the documented execution
order in the README. Remove stale comments that incorrectly stated
container and benchmark tests were commented out. Correct the README
to reflect that the release workflow is triggered only by
workflow_dispatch, not push.
ai-dev-branch commit IDs:
6ba7a2c
cb1bc7c
d39feb9
c9ffef7
The prompts used are captured in the footers of those commits.
The initial prompt was: the tags of xgboost are 3.0-5, 3.0-5-1.0.15.0, 3.0-5-cpu-py3, we need to maintain this in the repo config
---
X-AI-Handle-Time-Seconds: 301
X-AI-Line-Changes: New:15, Altered:7, Deleted:14
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:15, Altered:7, Deleted:14
X-AI-Handle-Time-Seconds-Kiro-cli: 301
X-AI-Change-Count: 4
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 4
X-CR-Amendment: false
aws-deep-learning-containers-ci
Bot
added
authorized
Size:XS
--- X-AI-Tool: Kiro-cli X-AI-Handle-Time-Seconds: 318 X-AI-Prompt: so there are precommit checks which is a job that checks the syntax, when i raised a pr it passes but for my teammates the xgboost files fail in pre commit checks why is this happening
fix: simplify XGBoost CI tags, fix integ test ordering, and resolve typos pre-commit failure
Simplify the CI image tags for XGBoost PR and release workflows by
removing the cuda version, OS version, and sagemaker suffix. The
tags now follow the pattern xgboost-{version}-{device}-{python}-{id}
which aligns with the public release tag scheme.
Fix the integration test workflow so that E2E tests depend on
container tests completing first, matching the documented execution
order in the README. Remove stale comments that incorrectly stated
container and benchmark tests were commented out. Correct the README
to reflect that the release workflow is triggered only by
workflow_dispatch.
Add certifi to the typos allow list in _typos.toml to fix
pre-commit failures on all PRs caused by the typos checker
flagging the Python package name in the XGBoost Dockerfile.
ai-dev-branch commit IDs:
6ba7a2c
cb1bc7c
d39feb9
c9ffef7
39ca9b1
The prompts used are captured in the footers of those commits.
The initial prompt was: the tags of xgboost are 3.0-5, 3.0-5-1.0.15.0, 3.0-5-cpu-py3, we need to maintain this in the repo config
---
X-AI-Handle-Time-Seconds: 318
X-AI-Line-Changes: New:1, Altered:0, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:1, Altered:0, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 318
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
bhanutejagk
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).