feat: add diagnostic logging to EFA NCCL test#6114
Merged
Conversation
Eren-Jeager123
changed the title
Eren-Jeager123
changed the title
Eren-Jeager123
changed the title
Eren-Jeager123
changed the title
Eren-Jeager123
force-pushed
the
debug-efa
branch
2 times, most recently
from
ddb9389 to
eb65273
Compare
- Print host driver version and cuda-compat version before test (catches driver mismatch issues like the embargo incident) - Capture NCCL allreduce stdout/stderr/log on failure instead of losing output through fabric's exception handling
Eren-Jeager123
changed the title
Yadan-Wei
approved these changes
May 21, 2026
Yadan-Wei
pushed a commit
that referenced
this pull request
May 22, 2026
The merge of main (PR #6114, 956819d) added warn=True to a run_on_container() call. Our verbose-_step refactor (9522545) wraps that same call inside a local _step() helper which doesn't accept warn, so the merge produced _step(..., warn=True) — TypeError at runtime. _step already prints stdout/stderr/exit on success and pytest captures the UnexpectedExit on failure, so warn=True is no longer needed (it was only useful when the broken DLAMI was masking real errors). Signed-off-by: Yadan Wei <yadanwei@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add diagnostic logging to the EFA test so future failures are easier to diagnose without manual SSH debugging.
Changes (test_efa.py only)
warn=Trueon the NCCL allreduce command to capture stdout/stderr/log on failure instead of losing output through fabric's exception handlingContext
The EFA test was failing for ~2 weeks due to a DLAMI embargo driver (580.150) incompatible with CUDA 13.0.2 on A100. The failure message (
system not yet initialized) gave no indication of the driver mismatch. These diagnostics would have identified the root cause immediately by showing:Now resolved by DLAMI team publishing the post-embargo AMI.
Test plan